Skip to content

SONARKT-659 Deprecate rule S6291 and S6300 #5031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2025
Merged

SONARKT-659 Deprecate rule S6291 and S6300 #5031

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e01e6a
Deprecate rule S6291
pierre-loup-tristant-sonarsource May 9, 2025
41c19de
Deprecate rule S6300
pierre-loup-tristant-sonarsource May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions rules/S6291/metadata.json
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on this process, we need to remove all tags and all quality profiles from the rule.
Regarding replacementRules: I don't think there is any rule that we may consider even a partial replacement, but I'll let you check.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also wonder whether we should keep the security standards, as they have an impact on security reports.
Do we still want for the rule to appear in those?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we deprecated the rule it will impact the security report if it's manually added to a quality profile right?
If this is the case, I would keep the security profile mapping in case some user want to keep using the rule.

Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,12 @@
},
"attribute": "TRUSTWORTHY"
},
"status": "ready",
"status": "deprecated",
"remediation": {
"func": "Constant\/Issue",
"constantCost": "10min"
},
"tags": [
"cwe",
"android"
],
"tags": [],
"extra": {
"replacementRules": [

Expand Down Expand Up @@ -64,8 +61,6 @@
"6.1.3"
]
},
"defaultQualityProfiles": [
"Sonar way"
],
"defaultQualityProfiles": [],
"quickfix": "unknown"
}
8 changes: 2 additions & 6 deletions rules/S6300/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,12 @@
},
"attribute": "TRUSTWORTHY"
},
"status": "ready",
"status": "deprecated",
"remediation": {
"func": "Constant\/Issue",
"constantCost": "10min"
},
"tags": [
"cwe",
"android"
],
"tags": [],
"extra": {
"replacementRules": [

Expand Down Expand Up @@ -61,7 +58,6 @@
]
},
"defaultQualityProfiles": [
"Sonar way"
],
"quickfix": "unknown"
}