-
Notifications
You must be signed in to change notification settings - Fork 31
SONARKT-659 Deprecate rule S6291 and S6300 #5031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@pierre-loup-tristant-sonarsource Changed the title of the PR to align with this convention. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on this process, we need to remove all tags and all quality profiles from the rule.
Regarding replacementRules
: I don't think there is any rule that we may consider even a partial replacement, but I'll let you check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also wonder whether we should keep the security standards, as they have an impact on security reports.
Do we still want for the rule to appear in those?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once we deprecated the rule it will impact the security report if it's manually added to a quality profile right?
If this is the case, I would keep the security profile mapping in case some user want to keep using the rule.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments above
5ccb98f
to
4e01e6a
Compare
@pierre-loup-tristant-sonarsource CI is failing, see here. I think you need to add back the |
5c23bad
to
41c19de
Compare
|
|
SONARKT-659
Review
A dedicated reviewer checked the rule description successfully for: