Skip to content

SONARKT-659 Deprecate rule S6291 and S6300 #5031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2025
Merged

Conversation

pierre-loup-tristant-sonarsource
Copy link
Contributor

@pierre-loup-tristant-sonarsource pierre-loup-tristant-sonarsource commented May 9, 2025

SONARKT-659

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title Modify S6291: deprecate the rule SONARKT-657 Modify S6291: deprecate the rule May 9, 2025
@pierre-loup-tristant-sonarsource pierre-loup-tristant-sonarsource changed the title SONARKT-657 Modify S6291: deprecate the rule SONARKT-654 Modify S6291: deprecate the rule May 9, 2025
@antonioaversa antonioaversa self-requested a review May 9, 2025 08:17
@antonioaversa antonioaversa changed the title SONARKT-654 Modify S6291: deprecate the rule SONARKT-654 Deprecate rule S6291 May 9, 2025
@antonioaversa
Copy link
Contributor

@pierre-loup-tristant-sonarsource Changed the title of the PR to align with this convention.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on this process, we need to remove all tags and all quality profiles from the rule.
Regarding replacementRules: I don't think there is any rule that we may consider even a partial replacement, but I'll let you check.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also wonder whether we should keep the security standards, as they have an impact on security reports.
Do we still want for the rule to appear in those?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we deprecated the rule it will impact the security report if it's manually added to a quality profile right?
If this is the case, I would keep the security profile mapping in case some user want to keep using the rule.

@antonioaversa antonioaversa self-requested a review May 9, 2025 08:24
Copy link
Contributor

@antonioaversa antonioaversa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments above

@antonioaversa
Copy link
Contributor

@pierre-loup-tristant-sonarsource CI is failing, see here. I think you need to add back the tags, and leaves the list empty.

@pierre-loup-tristant-sonarsource pierre-loup-tristant-sonarsource changed the title SONARKT-654 Deprecate rule S6291 SONARKT-659 Deprecate rule S6291 May 13, 2025
@pierre-loup-tristant-sonarsource pierre-loup-tristant-sonarsource changed the title SONARKT-659 Deprecate rule S6291 SONARKT-659 Deprecate rule S6291 and S6300 May 13, 2025
Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@antonioaversa antonioaversa added this pull request to the merge queue May 21, 2025
Merged via the queue into master with commit 119aef5 May 21, 2025
9 of 10 checks passed
@antonioaversa antonioaversa deleted the plt/sonarkt-654 branch May 21, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants