-
Notifications
You must be signed in to change notification settings - Fork 31
DART-262 Modify rule S2245: Add Dart language #4987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
antonioaversa
merged 3 commits into
master
from
antonio/DART-262-S2245-add-dart-language
May 21, 2025
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
{ | ||
"securityStandards": { | ||
"CWE": [ | ||
326, | ||
330, | ||
338, | ||
1241 | ||
], | ||
"OWASP": [ | ||
"A3" | ||
], | ||
"OWASP Mobile": [ | ||
"M5" | ||
], | ||
"OWASP Mobile Top 10 2024": [ | ||
"M10" | ||
], | ||
"MASVS": [ | ||
"MSTG-CRYPTO-6" | ||
], | ||
"OWASP Top 10 2021": [ | ||
"A2" | ||
], | ||
"ASVS 4.0": [ | ||
"6.2.4" | ||
] | ||
}, | ||
"quickfix": "unknown" | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
include::../description.adoc[] | ||
|
||
include::../ask-yourself.adoc[] | ||
|
||
include::../recommended.adoc[] | ||
|
||
== Sensitive Code Example | ||
|
||
[source,dart,diff-id=1,diff-type=noncompliant] | ||
---- | ||
import 'dart:math'; | ||
|
||
final random = Random(); // Noncompliant: Random() is not a secure random number generator | ||
final randomByte = random.nextInt(256); | ||
---- | ||
|
||
== Compliant Solution | ||
|
||
[source,dart,diff-id=1,diff-type=compliant] | ||
---- | ||
import 'dart:math'; | ||
|
||
final random = Random.secure(); // Compliant: Random.secure() is a secure random number generator | ||
antonioaversa marked this conversation as resolved.
Show resolved
Hide resolved
|
||
final randomByte = random.nextInt(256); | ||
---- | ||
|
||
include::../see.adoc[] | ||
|
||
* OWASP - https://mas.owasp.org/checklists/MASVS-CRYPTO/[Mobile AppSec Verification Standard - Cryptography Requirements] | ||
* OWASP - https://owasp.org/www-project-mobile-top-10/2016-risks/m5-insufficient-cryptography[Mobile Top 10 2016 Category M5 - Insufficient Cryptography] | ||
* OWASP - https://owasp.org/www-project-mobile-top-10/2023-risks/m10-insufficient-cryptography[Mobile Top 10 2024 Category M10 - Insufficient Cryptography] | ||
|
||
ifdef::env-github,rspecator-view[] | ||
|
||
''' | ||
== Implementation Specification | ||
(visible only on this page) | ||
|
||
include::../message.adoc[] | ||
|
||
''' | ||
== Comments And Links | ||
(visible only on this page) | ||
|
||
include::../comments-and-links.adoc[] | ||
|
||
endif::env-github,rspecator-view[] |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.