Skip to content

DART-262 Modify rule S2245: Add Dart language #4987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 21, 2025

Conversation

antonioaversa
Copy link
Contributor

@antonioaversa antonioaversa commented May 1, 2025

DART-262

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@antonioaversa antonioaversa marked this pull request as ready for review May 1, 2025 15:51
@antonioaversa antonioaversa force-pushed the antonio/DART-262-S2245-add-dart-language branch from 93881fe to 128b683 Compare May 1, 2025 16:31
Copy link
Contributor

@egon-okerman-sonarsource egon-okerman-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, fixed some formatting to be consistent with other rules

antonioaversa and others added 2 commits May 5, 2025 18:15
Co-authored-by: Egon Okerman <egon.okerman@sonarsource.com>
Co-authored-by: Egon Okerman <egon.okerman@sonarsource.com>
Copy link

sonarqube-next bot commented May 5, 2025

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

sonarqube-next bot commented May 5, 2025

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@antonioaversa antonioaversa added this pull request to the merge queue May 21, 2025
Merged via the queue into master with commit cbb392f May 21, 2025
8 of 9 checks passed
@antonioaversa antonioaversa deleted the antonio/DART-262-S2245-add-dart-language branch May 21, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants