Skip to content

fix(Desktop Library): add common blacklist and extra search folders #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025
Merged

fix(Desktop Library): add common blacklist and extra search folders #447

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions core/systems/library/library_desktop.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@ var home := OS.get_environment("HOME")
var desktop_folders := settings_manager.get_value(
"library.desktop",
"folders",
["/".join([home, ".local/share/applications"]), "/usr/share/applications"]
["/".join([home, ".local/share/applications"]), "/usr/share/applications", "/run/current-system/sw/share/applications"]
) as Array
var blacklist := settings_manager.get_value("library.desktop", "blacklist", ["steam steam://open/friends"]) as Array


func _ready() -> void:
Expand All @@ -18,7 +19,7 @@ func get_library_launch_items() -> Array:
for folder in desktop_folders:
logger.debug("Searching for .desktop files in: " + folder)
if not DirAccess.dir_exists_absolute(folder):
logger.warn("Folder does not exist: " + folder)
logger.debug("Folder does not exist: " + folder)
continue
var files := DirAccess.get_files_at(folder)
for file in files:
Expand Down Expand Up @@ -69,6 +70,14 @@ func _desktop_file_to_launch_item(file: String) -> LibraryLaunchItem:
# Apply any launch quirks if applicable
_apply_quirks(launch_item)

# Check to see if the command exists in the blacklist
for item in blacklist:
var cmd := launch_item.command + " ".join(launch_item.args)
if item != cmd:
continue
logger.debug("Desktop item '" + file + "' is blacklisted. Skipping.")
return null

return launch_item


Expand Down