Skip to content

Towards nominals #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 32 commits into from
May 23, 2025
Merged

Towards nominals #70

merged 32 commits into from
May 23, 2025

Conversation

4ever2
Copy link
Collaborator

@4ever2 4ever2 commented Apr 30, 2025

@MarkusKL
Copy link
Contributor

MarkusKL commented May 1, 2025

Merge checklist:

@spitters
Copy link
Contributor

spitters commented May 9, 2025

Do you depend on solving the universe issue, or can that be done in a separate PR?

@4ever2
Copy link
Collaborator Author

4ever2 commented May 9, 2025

Do you depend on solving the universe issue, or can that be done in a separate PR?

The universe issue is not a problem here. We don't plan on removing choice_type in this PR.

@4ever2 4ever2 changed the title [WIP] Towards nominals Towards nominals May 9, 2025
@4ever2
Copy link
Collaborator Author

4ever2 commented May 9, 2025

@MarkusKL
There are some minor conflicts with the changes from #73.

Disregard the MC-dev CI failure, they are unrelated to these changes. I'll fix it in another PR.

@spitters spitters requested a review from cmester0 May 9, 2025 09:37
@4ever2
Copy link
Collaborator Author

4ever2 commented May 9, 2025

@MarkusKL
CI issue is now fixed.

Feel free to add a reference to the nominal paper in the readme, either in this PR or in the PR integrating nominal.

@spitters
Copy link
Contributor

spitters commented May 9, 2025

@cmester0 will this require any modifications for the hax backend? Could you check that all our examples still compile?

@spitters
Copy link
Contributor

spitters commented May 9, 2025

LGTM

@MarkusKL
Copy link
Contributor

MarkusKL commented May 9, 2025

I will add a reference to the paper in a week or two when it has been finalized for CSF and is online. Thanks for all of the comments, reviews and fixes.

@MarkusKL
Copy link
Contributor

I have rebased this branch on current main in my own repository: MarkusKL#7
I would suggest to override this branch with the rebased branch wait for builds to succeed and then merge as soon as possible to put these changes into main. Or is there something else that needs to be done before this can be merged? I will then make a new PR for nominal definitions, theorems and examples.

@4ever2 4ever2 force-pushed the towards-nominals branch from 17648ff to 4cf9fbe Compare May 23, 2025 11:42
Copy link
Collaborator

@cmester0 cmester0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes required by Hax are removing trimmed and Parable proofs, or some renaming/updating to use fmaps. There should be nothing blocking from Hax, I will just fix everything once this is merged.

@4ever2 4ever2 marked this pull request as ready for review May 23, 2025 12:10
@4ever2 4ever2 merged commit 7887127 into main May 23, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants