-
Notifications
You must be signed in to change notification settings - Fork 13
Reversible coercion from choice_type #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
MarkusKL
wants to merge
35
commits into
SSProve:towards-nominals
Choose a base branch
from
MarkusKL:reversible-choice_type
base: towards-nominals
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Reversible coercion from choice_type #77
MarkusKL
wants to merge
35
commits into
SSProve:towards-nominals
from
MarkusKL:reversible-choice_type
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base Locations and Interfaces on finite maps.
… automation and examples
…ade jasmin files less chatty
Remove ordType instance on choice_type
Nice! BTW we've discussed using Deriving, but I'm not sure we're actually doing this at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This should be redirected to main once #70 has been merged)
I do not intend this to be merged for now. I just want to show progress and discuss ideas and ramifications.
I have managed to make a reversible coercion from choice_type, which allows us to derive much more type information by unification. The following checks are valid and derive the appropriate type information. The checks fail without a reversible coercion.
The changes this will allow are vast. It would allow us to:
This should also fix some of the issues with using assert, as it is defined over choice_type. In contrast, raw_code is defined over choiceType which already has a reversible coercion through HB.
I had to make two changes to the existing code:
rreflexivity_rule
. I am not sure why it is necessary and without the fix it only breaks deep withinSigmaProtocol.v
.SymmRatched.v
the lemmacode_link_map_loop
that was added to the simplification database actually works, so manual invocations can be removed.