Move PMTBeamSignal data product from icaruscode to sbnobj #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvicenzi
reviewed
Jun 2, 2025
This was referenced Jun 3, 2025
mvicenzi
approved these changes
Jun 3, 2025
aheggest
moved this from Open pull requests
to PR in progress
in SBN software development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request (together with icaruscode PR #832) moves the PMTBeamSignal data product from
icaruscode/IcarusObjto a SBN common area,sbnobj/Common.This PR moves what was previously defined in icaruscode/IcarusObj/PMTBeamSignal.h to sbnobj/Common/PMT/Data/PMTBeamSignal.hh and adds two helper functions
SelectFirstOpHitByTimeandgetFlashBunchTimeto help reconstruct the Beam Bunch structure seen by ICARUS PMTs later in the CAFs.This PR is a part of a PR pair: