-
Notifications
You must be signed in to change notification settings - Fork 35
Move PMTBeamSignal data product from icaruscode to sbnobj #832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty straighforward, but I have just two minor comments below.
This reverts commit ffbcc35.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few more comments on the recent additions.
The most important is making the namespace converter more general to be able to handle both RWM
and EW
products. There is no current need for it, but you never know.
trigger build larsoft@v10_06_00 LArSoft/lar*@LARSOFT_SUITE_v10_06_00 SBNSoftware/sbnalg@v10_06_00_01 SBNSoftware/sbncode@v10_06_00_01 SBNSoftware/sbnobj#130 |
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
This pull request (together with sbnobj PR #130) moves the PMTBeamSignal data product from
icaruscode/IcarusObj
to a SBN common area,sbnobj/Common
. This enables the special RWM signals digitized by the PMTs to be read into the CAFs.The main changes in this PR are switching all
icarus::timing::PMTBeamSignal
-->sbn::timing::PMTBeamSignal
and removing the previous defintion in PMTBeamSignal.h.This PR is a part of a PR pair:
To fully get the information into the CAFs, sbncode PR#541 and sbnanaobj PR#141 should also be merged in, but this icaruscode PR #832 and sbnobj PR #130 do not rely on sbncode PR#541 and sbnanaobj PR#141.
Added a simple producer module PMTBeamSignalNameSpaceConverter_module.cc to convert the PMTBeamSignal from
icarus::timing
namespace tosbn::timing
. This is to help with backward compatibility for files that were produced withicarus::timing::PMTBeamSignal
- we can convert the data product to the correctsbn::timing
namespace needed to be read into the CAFs.