-
-
Notifications
You must be signed in to change notification settings - Fork 34
Switching to pnpm
#2428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
RobinTail
wants to merge
75
commits into
master
Choose a base branch
from
try-pnpm-again
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4,150
−3,169
Draft
Switching to pnpm
#2428
Changes from all commits
Commits
Show all changes
75 commits
Select commit
Hold shift + click to select a range
e5230ed
Migrating lock file and workspaces to PNPM 10.
RobinTail b488446
Using pnpm -F for workspaces.
RobinTail ef5381b
Installing linting dependencies to the root.
RobinTail d12037e
Enabling Corepack for CI.
RobinTail 7e8e458
Using pnpm cache by setup node action.
RobinTail 5786a8d
mv corepack before node setup.
RobinTail d11f606
temp: no cache.
RobinTail 26825bb
Changing pm in CI.
RobinTail 7ad3e72
Fixed dependencies for running tests.
RobinTail 117b1fa
Address corepack integrity issue: rm sha.
RobinTail 0342d83
Revert "Address corepack integrity issue: rm sha."
RobinTail da5104b
Temp: Disabling corepack integrity keys.
RobinTail 259ec80
Fixing non-portable types for DTS build.
RobinTail 5da7161
Fix postbuild ATTW.
RobinTail 1a0b2d6
Replacing yarn in several commands.
RobinTail 7bf9b29
Add cross workspace reference to example (fixes build).
RobinTail 968e099
Add undici dev dep to example test.
RobinTail d0a8db5
Add cross ws ref to intergration tests.
RobinTail 3e5b7af
Fix env for the test of issue 952.
RobinTail 441fa39
Update validations.yml
RobinTail 48472b9
Update validations.yml
RobinTail 769132b
Update validations.yml
RobinTail 7cf5697
Update validations.yml
RobinTail 24f10cb
Using working dir approach due to pnpm bug.
RobinTail d2719b7
Add corepack to compat test.
RobinTail ae44d07
Fix corepack keys for compat test.
RobinTail 58b83d9
Using parser dependency in compat test.
RobinTail 5b8f536
And utils in compat test.
RobinTail 0c386d1
Replacing last yarn commands with pnpm, incl. contributing guide.
RobinTail 23e21b0
Hoist @typescript-eslint/* and @vitest/* publicly.
RobinTail a310ad4
Publicly hoisting @eslint/* and globals.
RobinTail bfbb46b
Correcting deps upgtade CI.
RobinTail a592eb2
Correcting publishing command in CI.
RobinTail e4f6781
REF: using lastest corepack instead of disabling key integrity check.
RobinTail b7db89a
Add corepack to the rest of the CI workflows.
RobinTail a848f46
Merge branch 'master' into try-pnpm-again
RobinTail b85fc9c
Trying pnpm/action-setup instead of corepack to enable cache in CI by…
RobinTail c034dfc
Replacing corepack in the rest of the CI workflows.
RobinTail a1eedab
Compat test can actually have yarn.
RobinTail 992b22f
Merge branch 'master' into try-pnpm-again
RobinTail 1dd70af
rm self ref in eslint config for allowed deps.
RobinTail f8ea6d3
Fix dependencies for headers tool.
RobinTail 0cd3a09
Merge branch 'master' into try-pnpm-again
RobinTail 2a6ea63
Merge branch 'master' into try-pnpm-again
RobinTail dfc8a97
Merge branch 'master' into try-pnpm-again
RobinTail d8aa58f
Merge branch 'master' into try-pnpm-again
RobinTail 0dbf8fe
FIX: DTS build for server functions without type reassignment.
RobinTail 048f6ef
Rev: type assertions in testing.
RobinTail 47ff82b
Reducing diff for testing.
RobinTail 01b02cc
Ref: moving qs fix into index entrypoint.
RobinTail b1cdbfc
rm dev dependencies in 952 test.
RobinTail aa6095b
Merge branch 'master' into try-pnpm-again
RobinTail c984fa7
Using exec workaround for versioning CI.
RobinTail 94fac22
Fix version command in CI.
RobinTail f20cd39
Using working directory because postversion fires too early.
RobinTail a5a65b6
Having to use npm instead.
RobinTail 3be2453
Trying bumpp.
RobinTail 1794d24
Trying bumpp.
RobinTail 843f123
chore: release v22.12.0-beta.1
github-actions[bot] 2753089
Using npm for publishing.
RobinTail d9eb03d
Trying pnpm dlx for versioning.
RobinTail 44093e9
Revert "Trying pnpm dlx for versioning."
RobinTail ec717c0
Merge branch 'master' into try-pnpm-again
RobinTail ba05a44
Merge branch 'master' into try-pnpm-again
RobinTail fc110a8
Fix express resolution to v5 when running pnpm upgrade.
RobinTail 6248647
Include root workspace to the dependencies upgrading CI.
RobinTail e4f1840
Add deduplication command to the dependencies upgrading workflow.
RobinTail a94d4d9
Merge branch 'master' into try-pnpm-again
RobinTail 9a089c1
rm qs workaround.
RobinTail fc8bb3b
Revert "rm qs workaround."
RobinTail 83855d5
Merge branch 'master' into try-pnpm-again
RobinTail 67ab55a
Upgrading pnpm to 10.10.0.
RobinTail 9a5422f
Enabling building esbuild.
RobinTail 7a00e85
moving from .npmrc to workspaces config.
RobinTail ceb7d50
restore .npmrc in .gitignore
RobinTail File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -10,11 +10,14 @@ jobs: | |||||
runs-on: ubuntu-latest | ||||||
steps: | ||||||
- uses: actions/checkout@v4 | ||||||
- uses: pnpm/action-setup@v4 | ||||||
- uses: actions/setup-node@v4 | ||||||
with: | ||||||
node-version: 20 | ||||||
cache: pnpm | ||||||
- uses: fregante/setup-git-user@v2 | ||||||
- run: | | ||||||
yarn install | ||||||
yarn install_hooks | ||||||
- run: yarn workspace express-zod-api version --minor | ||||||
pnpm install | ||||||
pnpm install_hooks | ||||||
- run: npx bumpp minor -y | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
working-directory: express-zod-api |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -10,11 +10,14 @@ jobs: | |||||
runs-on: ubuntu-latest | ||||||
steps: | ||||||
- uses: actions/checkout@v4 | ||||||
- uses: pnpm/action-setup@v4 | ||||||
- uses: actions/setup-node@v4 | ||||||
with: | ||||||
node-version: 20 | ||||||
cache: pnpm | ||||||
- uses: fregante/setup-git-user@v2 | ||||||
- run: | | ||||||
yarn install | ||||||
yarn install_hooks | ||||||
- run: yarn workspace express-zod-api version --patch | ||||||
pnpm install | ||||||
pnpm install_hooks | ||||||
- run: npx bumpp patch -y | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
working-directory: express-zod-api |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
yarn precommit | ||
pnpm precommit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.