Skip to content

Switching to pnpm #2428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 75 commits into
base: master
Choose a base branch
from
Draft

Switching to pnpm #2428

wants to merge 75 commits into from

Conversation

RobinTail
Copy link
Owner

@RobinTail RobinTail commented Feb 21, 2025

Reiterating #2067
Based on the findings of #2427
And using the advantage of having workspaces introduced in #2374

@RobinTail RobinTail added dependencies Pull requests that update a dependency file CI/CD miracle Mysterious events are happening here labels Feb 21, 2025
Copy link

coveralls-official bot commented Feb 21, 2025

Coverage Status

coverage: 100.0%. remained the same
when pulling ceb7d50 on try-pnpm-again
into 7541f38 on master.

@RobinTail
Copy link
Owner Author

✅ no regression in the release

This was referenced Feb 25, 2025
@RobinTail RobinTail marked this pull request as draft February 26, 2025 12:11
@RobinTail
Copy link
Owner Author

RobinTail commented Feb 26, 2025

I'm not fully satisfied with the current state of pnpm and therefore wanna try bun as well

@RobinTail RobinTail mentioned this pull request Feb 26, 2025
Copy link

socket-security bot commented May 12, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License

View full report

@RobinTail
Copy link
Owner Author

pnpm pack with -F should be fixed by pnpm/pnpm@fdb1d98#diff-8e62cd41ce2f44db44f930fb4625319e92015a4926124101432dc8a13ced3015, but it's not yet released

- run: yarn workspace express-zod-api version --minor
pnpm install
pnpm install_hooks
- run: npx bumpp minor -y
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- run: npx bumpp minor -y
- run: pnpm dlx bumpp minor -y

- run: yarn workspace express-zod-api version --patch
pnpm install
pnpm install_hooks
- run: npx bumpp patch -y
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- run: npx bumpp patch -y
- run: pnpm dlx bumpp patch -y

- run: yarn workspace express-zod-api version --pre${{ inputs.kind }} --preid beta
pnpm install
pnpm install_hooks
- run: npx bumpp pre${{ inputs.kind }} --preid beta -y
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- run: npx bumpp pre${{ inputs.kind }} --preid beta -y
- run: pnpm dlx bumpp pre${{ inputs.kind }} --preid beta -y

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation miracle Mysterious events are happening here
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant