Skip to content

[0.8] Implement optimized BF16 support for ARM architecture - [MOD-9079] #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2025

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Apr 6, 2025

Description

Backport of #623 to 0.8.

)

* SVE implementation for bf16

* add required build flags and fix implementation

* final fixes and implement benchmarks

* added tests

* implement neon bf16 distance functions

* implement build flow and benchmarks

* added test

* format

* remove redundant check

* typo fix

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* fixes and cleanup

* fix build

* fix svwhilelt_b16 calls

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
(cherry picked from commit bb41732)
@GuyAv46 GuyAv46 marked this pull request as draft April 6, 2025 16:31
@GuyAv46 GuyAv46 marked this pull request as ready for review April 6, 2025 16:31
@GuyAv46 GuyAv46 self-requested a review April 6, 2025 16:31
Copy link

codecov bot commented Apr 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.94%. Comparing base (95bef4e) to head (2cda111).
Report is 1 commits behind head on 0.8.

Additional details and impacted files
@@           Coverage Diff           @@
##              0.8     #641   +/-   ##
=======================================
  Coverage   96.94%   96.94%           
=======================================
  Files          91       91           
  Lines        5069     5069           
=======================================
  Hits         4914     4914           
  Misses        155      155           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

GuyAv46
GuyAv46 previously approved these changes Apr 6, 2025
@GuyAv46 GuyAv46 added this pull request to the merge queue Apr 6, 2025
github-merge-queue bot pushed a commit that referenced this pull request Apr 6, 2025
…79] (#641)

Implement optimized BF16 support for ARM architecture - [MOD-9079] (#623)

* SVE implementation for bf16

* add required build flags and fix implementation

* final fixes and implement benchmarks

* added tests

* implement neon bf16 distance functions

* implement build flow and benchmarks

* added test

* format

* remove redundant check

* typo fix

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* fixes and cleanup

* fix build

* fix svwhilelt_b16 calls

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
(cherry picked from commit bb41732)

Co-authored-by: GuyAv46 <47632673+GuyAv46@users.noreply.github.com>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 6, 2025
@GuyAv46 GuyAv46 added this pull request to the merge queue Apr 7, 2025
Merged via the queue into 0.8 with commit 1b4e500 Apr 7, 2025
20 checks passed
@GuyAv46 GuyAv46 deleted the backport-623-to-0.8 branch April 7, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant