Implement optimized BF16 support for ARM architecture - [MOD-9079] #623

GuyAv46 · 2025-03-31T16:01:45Z

Describe the changes in the pull request

Implement SVE and NEON (with fp16 fml) ARM optimizations for BFLOAT16

Mark if applicable

This PR introduces API changes
This PR introduces serialization changes

codecov · 2025-04-03T07:33:21Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.51%. Comparing base (b996755) to head (df2d2ca).
Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #623      +/-   ##
==========================================
- Coverage   97.19%   96.51%   -0.68%     
==========================================
  Files         106      106              
  Lines        5702     5745      +43     
==========================================
+ Hits         5542     5545       +3     
- Misses        160      200      +40

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Pull Request Overview

This PR implements optimized BFLOAT16 support on ARM by introducing new implementations for both SVE and NEON, along with corresponding test and benchmark updates.

Added new SVE_BF16 and NEON_BF16 source and header files that provide BF16 inner product and L2 norm functions.
Updated unit tests and benchmarks to cover the new ARM-specific BF16 implementations.
Integrated the new implementations into the selection logic in L2_space.cpp and IP_space.cpp based on detected CPU features.

Reviewed Changes

Copilot reviewed 13 out of 15 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
tests/unit/test_spaces.cpp	Added BF16 tests for NEON_BF16 and SVE_BF16 support
tests/benchmark/spaces_benchmarks/bm_spaces_bf16.cpp	Added ARM-specific benchmark initialization for BF16 modes
tests/benchmark/spaces_benchmarks/bm_spaces.h	Updated header includes for ARM BF16 optimizations
src/VecSim/spaces/functions/SVE_BF16.h & SVE_BF16.cpp	New SVE BF16 implementation functions
src/VecSim/spaces/functions/NEON_BF16.h & NEON_BF16.cpp	New NEON BF16 implementation functions
src/VecSim/spaces/L2_space.cpp	Integrated NEON_BF16 and SVE_BF16 optimizations into L2 function
src/VecSim/spaces/L2/L2_SVE_BF16.h	Added SVE BF16 L2 norm implementation
src/VecSim/spaces/L2/L2_NEON_BF16.h	Added NEON BF16 L2 norm implementation
src/VecSim/spaces/IP_space.cpp	Integrated NEON_BF16 and SVE_BF16 optimizations into inner product func
src/VecSim/spaces/IP/IP_SVE_BF16.h & IP_NEON_BF16.h	New BF16 inner product implementations for SVE and NEON

Files not reviewed (2)

cmake/aarch64InstructionFlags.cmake: Language not supported
src/VecSim/spaces/CMakeLists.txt: Language not supported

src/VecSim/spaces/IP/IP_NEON_BF16.h

dor-forer

Great job!

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

lerman25

Great work!

) * SVE implementation for bf16 * add required build flags and fix implementation * final fixes and implement benchmarks * added tests * implement neon bf16 distance functions * implement build flow and benchmarks * added test * format * remove redundant check * typo fix Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fixes and cleanup * fix build * fix svwhilelt_b16 calls --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> (cherry picked from commit bb41732)

github-actions · 2025-04-06T16:31:36Z

Successfully created backport PR for 0.8:

[0.8] Implement optimized BF16 support for ARM architecture - [MOD-9079] #641

) * SVE implementation for bf16 * add required build flags and fix implementation * final fixes and implement benchmarks * added tests * implement neon bf16 distance functions * implement build flow and benchmarks * added test * format * remove redundant check * typo fix Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fixes and cleanup * fix build * fix svwhilelt_b16 calls --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> (cherry picked from commit bb41732)

github-actions · 2025-04-06T16:31:39Z

Successfully created backport PR for 8.0:

[8.0] Implement optimized BF16 support for ARM architecture - [MOD-9079] #642

…79] (#641) Implement optimized BF16 support for ARM architecture - [MOD-9079] (#623) * SVE implementation for bf16 * add required build flags and fix implementation * final fixes and implement benchmarks * added tests * implement neon bf16 distance functions * implement build flow and benchmarks * added test * format * remove redundant check * typo fix Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fixes and cleanup * fix build * fix svwhilelt_b16 calls --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> (cherry picked from commit bb41732) Co-authored-by: GuyAv46 <47632673+GuyAv46@users.noreply.github.com>

…79] (#642) Implement optimized BF16 support for ARM architecture - [MOD-9079] (#623) * SVE implementation for bf16 * add required build flags and fix implementation * final fixes and implement benchmarks * added tests * implement neon bf16 distance functions * implement build flow and benchmarks * added test * format * remove redundant check * typo fix Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fixes and cleanup * fix build * fix svwhilelt_b16 calls --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> (cherry picked from commit bb41732) Co-authored-by: GuyAv46 <47632673+GuyAv46@users.noreply.github.com>

…79] (#641) * Implement optimized BF16 support for ARM architecture - [MOD-9079] (#623) * SVE implementation for bf16 * add required build flags and fix implementation * final fixes and implement benchmarks * added tests * implement neon bf16 distance functions * implement build flow and benchmarks * added test * format * remove redundant check * typo fix Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fixes and cleanup * fix build * fix svwhilelt_b16 calls --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> (cherry picked from commit bb41732) * fix benchmark macros for 0.8 --------- Co-authored-by: GuyAv46 <47632673+GuyAv46@users.noreply.github.com> Co-authored-by: GuyAv46 <guy.avimor@gmail.com>

GuyAv46 added backport 0.6 backport 0.7 backport 0.8 backport 8.0 labels Apr 2, 2025

GuyAv46 force-pushed the guyav-arm_fp16_support branch from 36c9295 to 7a768aa Compare April 3, 2025 06:50

GuyAv46 added 9 commits April 3, 2025 09:51

SVE implementation for bf16

600a2e4

add required build flags and fix implementation

b0796d4

final fixes and implement benchmarks

0470abe

added tests

ffcc6dc

implement neon bf16 distance functions

ed833c5

implement build flow and benchmarks

558451a

added test

9e762f6

format

61af8ec

remove redundant check

bb46609

GuyAv46 changed the base branch from guyav-arm_fp16_support to main April 3, 2025 06:54

GuyAv46 force-pushed the guyav-arm_bf16_support branch from 1de69d4 to bb46609 Compare April 3, 2025 06:54

GuyAv46 marked this pull request as ready for review April 3, 2025 06:54

GuyAv46 requested review from dor-forer and Copilot April 3, 2025 08:29

Copilot AI reviewed Apr 3, 2025

View reviewed changes

src/VecSim/spaces/IP/IP_NEON_BF16.h Outdated Show resolved Hide resolved

dor-forer previously approved these changes Apr 3, 2025

View reviewed changes

typo fix

1932f17

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

GuyAv46 dismissed dor-forer’s stale review via 1932f17 April 3, 2025 11:40

fixes and cleanup

cd6885a

GuyAv46 added bm-spaces and removed backport 0.6 backport 0.7 labels Apr 3, 2025

fix build

c842869

GuyAv46 requested a review from lerman25 April 3, 2025 15:08

GuyAv46 requested a review from dor-forer April 3, 2025 15:08

fix svwhilelt_b16 calls

df2d2ca

dor-forer approved these changes Apr 6, 2025

View reviewed changes

GuyAv46 mentioned this pull request Apr 6, 2025

Implement optimized FP16 support for ARM architecture - [MOD-9078] #620

Merged

2 tasks

lerman25 approved these changes Apr 6, 2025

View reviewed changes

GuyAv46 added this pull request to the merge queue Apr 6, 2025

Merged via the queue into main with commit bb41732 Apr 6, 2025
24 checks passed

GuyAv46 deleted the guyav-arm_bf16_support branch April 6, 2025 16:31

github-actions bot mentioned this pull request Apr 6, 2025

[0.8] Implement optimized BF16 support for ARM architecture - [MOD-9079] #641

Merged

github-actions bot mentioned this pull request Apr 6, 2025

[8.0] Implement optimized BF16 support for ARM architecture - [MOD-9079] #642

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Implement optimized BF16 support for ARM architecture - [MOD-9079] #623

Implement optimized BF16 support for ARM architecture - [MOD-9079] #623

Uh oh!

GuyAv46 commented Mar 31, 2025 •

edited

Loading

Uh oh!

codecov bot commented Apr 3, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

dor-forer left a comment

Uh oh!

lerman25 left a comment

Uh oh!

Uh oh!

github-actions bot commented Apr 6, 2025

Uh oh!

github-actions bot commented Apr 6, 2025

Uh oh!

Uh oh!

Implement optimized BF16 support for ARM architecture - [MOD-9079] #623

Implement optimized BF16 support for ARM architecture - [MOD-9079] #623

Uh oh!

Conversation

GuyAv46 commented Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Apr 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

dor-forer left a comment

Choose a reason for hiding this comment

Uh oh!

lerman25 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Apr 6, 2025

Uh oh!

github-actions bot commented Apr 6, 2025

Uh oh!

Uh oh!

GuyAv46 commented Mar 31, 2025 •

edited

Loading

codecov bot commented Apr 3, 2025 •

edited

Loading