[8.0] Raw vectors data layer in HNSW + move to base class [MOD-7496] #574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* use data blocks container in HNSW + adjust tests * Move vectors raw data to base class * fix for test serialization * fix test to be safe with parallel insertions * try lock only for get next results in batch iterator in bindings * todo * remove alignment from base index class + move vector allocation and destruction to base * Add serializer version that does not persist blocks (to be used in the future for other raw data layers) * Add test to cover old serialization version + small improvements * fix test * fix test for cov (cherry picked from commit 1e55ba7)
2 tasks
alonre24
approved these changes
Dec 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 8.0 #574 +/- ##
=======================================
Coverage 96.97% 96.98%
=======================================
Files 100 100
Lines 5297 5305 +8
=======================================
+ Hits 5137 5145 +8
Misses 160 160 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #523 to
8.0.