Raw vectors data layer in HNSW + move to base class [MOD-7496] #523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…estruction to base
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #523 +/- ##
==========================================
+ Coverage 96.93% 96.97% +0.04%
==========================================
Files 100 100
Lines 5287 5295 +8
==========================================
+ Hits 5125 5135 +10
+ Misses 162 160 -2 ☔ View full report in Codecov by Sentry. |
GuyAv46
reviewed
Nov 12, 2024
| void DataBlocksContainer::saveBlocks(std::ostream &output) const { | ||
| // Save number of blocks | ||
| unsigned int num_blocks = this->numBlocks(); | ||
| Serializer::writeBinaryPOD(output, num_blocks); |
There was a problem hiding this comment.
We should consider only saving the vectors without the metadata about the number of blocks and their sizes, so we can load them into other containers (or to different block sizes)
There was a problem hiding this comment.
This also means we don't need to add serialization to the container class, keeping it on the algorithm level
…e future for other raw data layers)
alonre24
changed the title
GuyAv46
approved these changes
Dec 19, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Dec 19, 2024
* use data blocks container in HNSW + adjust tests * Move vectors raw data to base class * fix for test serialization * fix test to be safe with parallel insertions * try lock only for get next results in batch iterator in bindings * todo * remove alignment from base index class + move vector allocation and destruction to base * Add serializer version that does not persist blocks (to be used in the future for other raw data layers) * Add test to cover old serialization version + small improvements * fix test * fix test for cov (cherry picked from commit 1e55ba7)
|
Successfully created backport PR for |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 19, 2024
…574) Raw vectors data layer in HNSW + move to base class [MOD-7496] (#523) * use data blocks container in HNSW + adjust tests * Move vectors raw data to base class * fix for test serialization * fix test to be safe with parallel insertions * try lock only for get next results in batch iterator in bindings * todo * remove alignment from base index class + move vector allocation and destruction to base * Add serializer version that does not persist blocks (to be used in the future for other raw data layers) * Add test to cover old serialization version + small improvements * fix test * fix test for cov (cherry picked from commit 1e55ba7) Co-authored-by: alonre24 <alon.reshef@redis.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
Use the new
RawDataContainerinterface in HNSW, currently with an explicitDataBlocksContainerimplementation, and move the abstractvectorsmember to the base class.This includes:
DataBlocksContainerresponsibility, as we should not access the blocks directly anymore (should be applied for the graph data blocks later on as well).Mark if applicable