Bump 2.3.7 #245
Bump 2.3.7 #245
Conversation
Signed-off-by: Hyungyu Kim <kimhg@robotis.com>
Add rosdep check ci in jazzy
Signed-off-by: Hyungyu Kim <kimhg@robotis.com>
Fix buildfarm error in rolling
There was a problem hiding this comment.
Pull Request Overview
Bump package versions to 2.3.7 while updating tf2/LinearMath header references from .h to .hpp and extending the changelog entries accordingly.
- Updated version numbers in package.xml files for turtlebot3_simulations, turtlebot3_gazebo, and turtlebot3_fake_node.
- Changed header includes in turtlebot3_gazebo and turtlebot3_fake_node to use .hpp extensions.
- Added a new CI workflow step for checking and installing ROS dependencies.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| turtlebot3_simulations/package.xml | Version bump update |
| turtlebot3_simulations/CHANGELOG.rst | Added changelog entry for version 2.3.7 with header file changes note |
| turtlebot3_gazebo/package.xml | Version bump update |
| turtlebot3_gazebo/include/turtlebot3_drive.hpp | Updated include directives to .hpp instead of .h |
| turtlebot3_gazebo/CHANGELOG.rst | Added changelog entry for version 2.3.7 with header file changes note |
| turtlebot3_fake_node/package.xml | Version bump update |
| turtlebot3_fake_node/include/turtlebot3_fake_node.hpp | Updated include directives to .hpp instead of .h |
| turtlebot3_fake_node/CHANGELOG.rst | Added changelog entry for version 2.3.7 (inconsistent package naming noted) |
| .github/workflows/ros-ci.yml | Added CI step to update rosdep and install system dependencies |
Comments suppressed due to low confidence (1)
turtlebot3_fake_node/CHANGELOG.rst:2
- The changelog title refers to 'turtlebot3_fake' while the package name is 'turtlebot3_fake_node'. Consider updating the changelog title for consistency.
Changelog for package turtlebot3_fake
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @robotpilot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily focuses on a version bump for several turtlebot3 simulation packages to 2.3.7. The core technical change involves updating the tf2/LinearMath header includes in the C++ source files to use the .hpp extension, aligning with modern C++ practices and potentially newer tf2 library conventions. This ensures continued compatibility and maintenance.
Highlights
- Version Bump: The version of
turtlebot3_fake_node,turtlebot3_gazebo, andturtlebot3_simulationspackages has been updated from 2.3.5 to 2.3.7. - Header File Modernization: C++ header includes for
tf2/LinearMathhave been updated from the.hextension to the modern.hppextension inturtlebot3_fake_node.hppandturtlebot3_drive.hpp. - Changelog Updates: Corresponding changelog entries have been added for version 2.3.7 in
CHANGELOG.rstfiles across the affected packages, documenting the header file change.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
| #define TURTLEBOT3_FAKE_NODE__TURTLEBOT3_FAKE_NODE_HPP_ | ||
|
|
||
| #include <tf2/LinearMath/Quaternion.h> | ||
| #include <chrono> |
There was a problem hiding this comment.
Moving this include below the other includes for better organization and readability.
| #include "geometry_msgs/msg/twist.hpp" | ||
| #include "nav_msgs/msg/odometry.hpp" | ||
| #include "sensor_msgs/msg/joint_state.hpp" | ||
| #include <tf2/LinearMath/Quaternion.hpp> |
There was a problem hiding this comment.
Moving this include from above to here to group related headers together.
| #include <geometry_msgs/msg/twist.hpp> | ||
| #include <nav_msgs/msg/odometry.hpp> | ||
| #include <rclcpp/rclcpp.hpp> | ||
| #include <sensor_msgs/msg/laser_scan.hpp> |
There was a problem hiding this comment.
Moving these includes below the other includes for better organization and readability.
| #include <tf2/LinearMath/Matrix3x3.hpp> | ||
| #include <tf2/LinearMath/Quaternion.hpp> |
There was a problem hiding this comment.
Moving these includes from above to here to group related headers together.
2 participants
No description provided.