-
Notifications
You must be signed in to change notification settings - Fork 512
Add humble rosdep ci #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add humble rosdep ci #243
Conversation
Signed-off-by: Hyungyu Kim <kimhg@robotis.com>
Signed-off-by: Hyungyu Kim <kimhg@robotis.com>
Signed-off-by: Hyungyu Kim <kimhg@robotis.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @GyuH13, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily updates the version numbers for several turtlebot3
simulation packages to 2.3.6
. It also incorporates a new dependency within the turtlebot3_simulations
metapackage, which is noted as part of broader CI configuration updates, aligning with the PR's intent to add Humble ROSdep CI support.
Highlights
- Version Increments: The
package.xml
files forturtlebot3_fake_node
,turtlebot3_gazebo
,turtlebot3_manipulation_gazebo
, andturtlebot3_simulations
have been updated to version2.3.6
. - Changelog Documentation: Corresponding
CHANGELOG.rst
files now include entries for the2.3.6
release, with theturtlebot3_simulations
changelog specifically mentioning the inclusion ofturtlebot3_manipulation_gazebo
and related CI configuration updates. - New Metapackage Dependency: The
turtlebot3_simulations
package now liststurtlebot3_manipulation_gazebo
as anexec_depend
, integrating it into the main simulation metapackage. - Historical Correction: A minor typo in the year
2202
was corrected to2022
within the changelog history ofturtlebot3_fake_node
andturtlebot3_simulations
.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR prepares the Humble Hawksbill release (v2.3.6) by bumping versions, updating changelogs, adding the new manipulation simulation package to the metapackage, and enhancing CI with rosdep dependency checks.
- Bump package versions from 2.3.4 → 2.3.6 and add
turtlebot3_manipulation_gazebo
as a runtime dependency in the simulations metapackage - Insert 2.3.6 entries into each package’s CHANGELOG, correcting historical release dates
- Add a "Check and Install ROS dependencies" step in CI and include the manipulation package in the build matrix
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
turtlebot3_simulations/package.xml | Version bump to 2.3.6 & added <exec_depend> for manipulation gazebo |
turtlebot3_simulations/CHANGELOG.rst | Added 2.3.6 release entry; fixed 2.2.6 date |
turtlebot3_manipulation_gazebo/package.xml | Version bump to 2.3.6 |
turtlebot3_manipulation_gazebo/CHANGELOG.rst | Added 2.3.6 release entry |
turtlebot3_gazebo/package.xml | Version bump to 2.3.6 |
turtlebot3_gazebo/CHANGELOG.rst | Added 2.3.6 release entry |
turtlebot3_fake_node/package.xml | Version bump to 2.3.6 |
turtlebot3_fake_node/CHANGELOG.rst | Added 2.3.6 release entry; fixed 2.2.6 date |
.github/workflows/ros-ci.yml | New rosdep installation/check step; added manipulation package to build |
Comments suppressed due to low confidence (2)
turtlebot3_simulations/CHANGELOG.rst:23
- The version heading has leading spaces which may break the changelog formatting. Align the
2.2.6 (2022-05-26)
line flush left, matching the other version headings.
2.2.6 (2022-05-26)
.github/workflows/ros-ci.yml:77
- [nitpick] Consider sorting the
package-name
list alphabetically to make it easier to locate and maintain packages in the CI configuration.
turtlebot3_manipulation_gazebo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates several TurtleBot3 simulation packages to version 2.3.6, primarily to integrate turtlebot3_manipulation_gazebo
into the turtlebot3_simulations
metapackage and align with ROS Humble CI efforts. Changes include version bumps, changelog updates (including typo corrections), and the addition of the new dependency. The review includes suggestions to enhance the clarity of changelog entries for sub-packages, recommending more descriptive notes if the version bumps are related to CI integration efforts, rather than just None
.
|
||
2.3.6 (2025-06-19) | ||
------------------ | ||
* None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
2.3.6 (2025-06-19) | ||
------------------ | ||
* None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding a more descriptive changelog entry than None
. If this package's update is tied to the "Add humble rosdep ci" effort, and involved specific setup, testing, or validation for turtlebot3_manipulation_gazebo
under Humble, a more informative note would be valuable. For example: Initial integration into Humble CI pipeline.
No description provided.