Skip to content

Conversation

GyuH13
Copy link
Member

@GyuH13 GyuH13 commented Jun 19, 2025

No description provided.

Signed-off-by: Hyungyu Kim <kimhg@robotis.com>
@Copilot Copilot AI review requested due to automatic review settings June 19, 2025 07:16
@gemini-code-assist
Copy link

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a dedicated step to update and verify ROS package dependencies via rosdep before the main build and test stage.

  • Introduces a “Check and Install ROS dependencies” bash step
  • Updates rosdep definitions and installs missing system dependencies
  • Fails early if any rosdep checks are unresolvable
Comments suppressed due to low confidence (2)

.github/workflows/ros-ci.yml:52

  • Consider extracting the inline bash script into a reusable GitHub Action (e.g., a custom rosdep action) or a separate shell script file to improve readability and reuse across workflows.
      - name: Check and Install ROS dependencies

.github/workflows/ros-ci.yml:60

  • Ensure the rosdep commands execute in the correct directory; add a working-directory: ros_ws to the step or prefix with cd ros_ws so paths resolve reliably.
          rosdep install --from-paths ros_ws/src --ignore-src -y -r --rosdistro ${{ matrix.ros_distribution }}

- name: Check and Install ROS dependencies
shell: bash
run: |
set -e
Copy link

Copilot AI Jun 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add caching for rosdep’s sources cache (using actions/cache) to avoid running rosdep update on every CI run and significantly speed up workflow execution.

Copilot uses AI. Check for mistakes.

@robotpilot robotpilot self-assigned this Jun 20, 2025
@robotpilot robotpilot enabled auto-merge June 20, 2025 02:44
@robotpilot robotpilot disabled auto-merge June 20, 2025 02:44
@robotpilot robotpilot merged commit d91df31 into main Jun 20, 2025
10 checks passed
@robotpilot robotpilot deleted the feature-jazzy-rosdep-ci branch June 20, 2025 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants