Skip to content
This repository was archived by the owner on Mar 27, 2025. It is now read-only.

Conversation

lindnemi
Copy link
Collaborator

We don't see variations in the industry sector yet -> requires a fix of modify_industry_demand @toniseibold

Before asking for a review for this PR make sure to complete the following checklist:

  • Workflow with target rule ariadne_all completes without errors
  • The logic of export_ariadne_variables has been adapted to the changes
  • One or several figures that validate the changes in the PR have been posted as a comment
  • A brief description of the changes has been added to Changelog.md
  • The latest main has been merged into the PR
  • The config has a new prefix of the format YYYYMMDDdescriptive_title

Copy link

github-actions bot commented Jan 23, 2025

Validator Report

I am the Validator. Download all artifacts here.
I'll be back and edit this comment for each new commit.

❗ Run failed!

Download 'logs' artifact to see more details.

  • main failed in: build_gas_network, base_network, build_industrial_production_per_country_tomorrow, build_industrial_production_per_country_tomorrow, build_industrial_production_per_country_tomorrow, build_industrial_production_per_country_tomorrow, build_industrial_production_per_country_tomorrow, build_industrial_production_per_country_tomorrow, build_industry_sector_ratios_intermediate, build_industry_sector_ratios_intermediate, build_industry_sector_ratios_intermediate, build_industry_sector_ratios_intermediate, build_industry_sector_ratios_intermediate, build_industry_sector_ratios_intermediate
  • demand-scenarios failed in: build_gas_network, base_network, build_industrial_production_per_country_tomorrow, build_industrial_production_per_country_tomorrow, build_industrial_production_per_country_tomorrow, build_industrial_production_per_country_tomorrow, build_industrial_production_per_country_tomorrow, build_industrial_production_per_country_tomorrow, build_industry_sector_ratios_intermediate, build_industry_sector_ratios_intermediate, build_industry_sector_ratios_intermediate, build_industry_sector_ratios_intermediate, build_industry_sector_ratios_intermediate, build_industry_sector_ratios_intermediate
⚠️ Config changes detected!

Results may differ due to these changes:

diff --git a/config/config.yaml b/config/config.yaml
index 0a8fe37..4fa17de 100644
--- a/config/config.yaml
+++ b/config/config.yaml
@@ -4,7 +4,7 @@
 
 # docs in https://pypsa-eur.readthedocs.io/en/latest/configuration.html#run
 run:
-  prefix: 20241203-force-onwind-south
+  prefix: 20250122-demand-scenarios
   name:
   # - CurrentPolicies
   - KN2045_Bal_v4
@@ -14,6 +14,8 @@ run:
   # - KN2045plus_LowDemand
   # - KN2045minus_WorstCase
   # - KN2045minus_SupplyFocus
+  # - KN2045_Bal_LowDemand
+  # - KN2045_Bal_HighDemand
   scenarios:
     enable: true
     manual_file: config/scenarios.manual.yaml

Model Metrics

Benchmarks Image not available Image not available Image not available

Comparing demand-scenarios (840cc3c) with main (2e84916).
Branch is 5 commits ahead and 0 commits behind.
Last updated on 2025-01-23 13:49:55 CET.

Copy link
Contributor

@toniseibold toniseibold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommendation for the scenarios.manual.yaml file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to repeat the config[solving][constraints] since they are the same in the config.yaml.
I would rather not repeat to keep the scenarios.manual.yaml file as short as possible which makes it easier to read and understand the differences between scenarios.

@lindnemi lindnemi merged commit fd114b0 into main Jan 23, 2025
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants