Skip to content

* moved HasMissingDependencies to UI thread #3631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 9, 2025
Merged

* moved HasMissingDependencies to UI thread #3631

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e21d07f
* moved HasMissingDependencies to UI thread to test Nick's theory
chambm Oct 8, 2025
9b6b47e
* converted property to method
chambm Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pwiz_tools/Skyline/TestFunctional/DiaSearchTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,6 @@ private class TestDetails
public MzTolerance FragmentMzTolerance { get; set; }
public List<KeyValuePair<string, string>> AdditionalSettings { get; set; }

public bool HasMissingDependencies => !SearchSettingsControl.HasRequiredFilesDownloaded(SearchEngine);

public class DocumentCounts
{
public int ProteinCount;
Expand Down Expand Up @@ -103,6 +101,8 @@ private void SetupDiaSearchVariableWindows()
};
}

public bool HasMissingDependencies() => CallUI(() => !SearchSettingsControl.HasRequiredFilesDownloaded(_testDetails.SearchEngine));

[TestMethod,
NoParallelTesting(TestExclusionReason.RESOURCE_INTENSIVE),
NoUnicodeTesting(TestExclusionReason.MSGFPLUS_UNICODE_ISSUES),
Expand Down Expand Up @@ -467,7 +467,7 @@ private void TestDiaUmpireSearch()
// Run the search
SkylineWindow.BeginInvoke(new Action(() => importPeptideSearchDlg.ClickNextButton()));

if (testDetails.HasMissingDependencies)
if (HasMissingDependencies())
{
if (testDetails.SearchEngine == SearchSettingsControl.SearchEngine.MSFragger)
{
Expand Down Expand Up @@ -759,7 +759,7 @@ private void TestDiaSearchPredicate()
// Run the search
SkylineWindow.BeginInvoke(new Action(() => Assert.IsTrue(importPeptideSearchDlg.ClickNextButton())));

if (testDetails.HasMissingDependencies)
if (HasMissingDependencies())
{
if (testDetails.SearchEngine == SearchSettingsControl.SearchEngine.MSFragger)
{
Expand Down