Skip to content

Conversation

eduardo-proteinms
Copy link
Collaborator

@eduardo-proteinms eduardo-proteinms commented Oct 3, 2024

This restructuring is automated so we can rerun if if we need to change the source before we merge this.

This PR changes the following:

  • Moves icon/button images to shared folder
  • Names all images which are not coming from Skyline using the format "s-name"
  • All other images are renamed / renumbered to the format "s-#"

This will make it simpler to output images from tutorial tests with a counter for now. Also we can use the s- prefix to add alt text / anchors in html programmatically

Example:
image

@eduardo-proteinms
Copy link
Collaborator Author

Will rerun script once #3180 is merged

@brendanx67
Copy link
Contributor

Looks great. Definitely an improvement on several levels. Please start the s-# with s-1 instead of s-0. These are not indices into an array. I know the # from s-# will not line up with "Figure #", but I still think it is better to have the s-# and Figure # both start with 1.

@brendanx67
Copy link
Contributor

I have merged PR #3180

@eduardo-proteinms
Copy link
Collaborator Author

Looks great. Definitely an improvement on several levels. Please start the s-# with s-1 instead of s-0. These are not indices into an array. I know the # from s-# will not line up with "Figure #", but I still think it is better to have the s-# and Figure # both start with 1.

Numbering starts at 1 now. This should be ready for merge.

@brendanx67 brendanx67 merged commit 5b26d91 into master Oct 9, 2024
@brendanx67 brendanx67 deleted the Skyline/work/20241003_ReformatTutorialImageStructure branch January 3, 2025 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants