AutoQC Loader updates #3131
Merged
AutoQC Loader updates #3131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from SkylineBatch and AutoQC. Move required methods to the PanoramaClient project.
…nt-in-skylinebatch-autoqc
…log tab 3. Stop the config.
…orting .wiff2 files.
- Do not force user to select "...a root folder for the configurations" if the .qcfg file being imported is in the "Downloads" folder. - Save the available Skyline options to user.config after initializing. Otherwise, Skyline and Skyline-daily options are disabled in the "Skyline" setting tab when creating a new configuration. - Deleted SignAfterPublish.bat
- Added AnnotationsFileWatcher.cs - Annotations file is imported when a change is detected.
…d, or the document already had imported replicates.
… to Panorama as long as the document has existing replicates. This should happen even if no existing raw data was found to import, or all existing raw data was skipped because it was older than the most recent replicate in the document.
…figuration with PanoramaSettings.ValidateSettings(true). This can throw both an ArgumentException and a PanoramaServerException which, in PanoramaClient project, does not inherit from ArgumentException.
- Fix bug: Config did not show "Error" status if there was an error uploading to Panorama, and the config was stopped manually.
AutoQcConfigManager.SetConfigEnabled() returns a new State with new config runners that do not copy the RunnerStatus from the current State.
- Fix bug: When the app starts, PanormaServer validation was happening in one background thread per configuration. This would cause a warning "The state of the configuration list has changed...". Configurations that failed Panorama server validation were not being displayed in red.
- Added DisableConfig and EnableConfig methods to AutoQcConfigManager.
…of VisualStudio warning about hiding an inherited member.
…imports to add or remove peptides...". Retrying will not work in this case.
…ted a second time. - Bug fix - config checkbox remained checked after it was stopped due to annotations import error - Uncommented code that was setting the status on a newly added config/config runner (replacing a config that was disabled) in case the config that was getting replaced had a status other than "Stopped". - Changed required permissions from "admin" to "insert". - Try to reimport annotations after retrying previously failed raw file imports. - String.format with resource strings
…fore importing annotations or uploading to Panorama. - If annotations import was unsuccessful, import them again in the ProcessOneFile() method, before uploading the document to Panorama. - Set the LastArchivalDate only if the archive sky.zip will be created.
…k/20240430_vsharma_autoqc-updates-pt2
…_autoqc-updates-pt2
- Fix logger
…k/20240821_vsharma_autoqc-updates-all
brendanx67
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
Generally the code looks okay to me. To get better coverage, you should walk me through how the changes impact the running program. I also wonder if there is some way that you could add new testing for the new annotations functionality. It doesn't look like any new testing was added, which would be required inside the Skyline project itself.
…ot enabled - Fix bug introduced during cleanup - make a copy of the initial AutoQC config state before attempting to change it.
…tps://github.com/ProteoWizard/pwiz into Skyline/work/20240821_vsharma_autoqc-updates-all
|
Functional tests will be added in a separate PR. |
vagisha
deleted the
Skyline/work/20240821_vsharma_autoqc-updates-all
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fixes: