Skip to content

Skyline: Fixes to translated HTML to match the fixes made to English #3180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2024
Merged

Skyline: Fixes to translated HTML to match the fixes made to English #3180

merged 1 commit into from
Oct 3, 2024

Conversation

@brendanx67
Copy link
Contributor

  • Fixed all links to other tutorials to go to translated versions when available

@brendanx67
Skyline: Fixes to translated HTML to match the fixes made to English
9cbc165 
- Fixed all links to other tutorials to go to translated versions when available
@brendanx67
Copy link
Contributor Author

Note that these changes have been posted on the skyline.ms website for testing.

@eduardo-proteinms
Copy link
Collaborator

looks good!

@eduardo-proteinms eduardo-proteinms mentioned this pull request Oct 3, 2024
Merged
nickshulman
nickshulman approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@nickshulman nickshulman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I ran:
quickbuild.bat pwiz_tools\Skyline\Executables\DevTools\TutorialLocalization
and the localization_ja.csv and localization_zh-CHS.csv files in the MergedTutorials.zip that was produced did not have anything suspicious in them.

@brendanx67 brendanx67 merged commit 6d542ed into master Oct 3, 2024
10 checks passed
@brendanx67 brendanx67 deleted the Skyline/work/20241003_html_tutorials_translation_fixes branch October 3, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickshulman nickshulman nickshulman approved these changes

@eduardo-proteinms eduardo-proteinms eduardo-proteinms approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brendanx67 @eduardo-proteinms @nickshulman