-
Notifications
You must be signed in to change notification settings - Fork 52
Update example apps' test data path, patch hsdk in local env, and ensure correct MD SDK is used in dev env #516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: M Q <mingmelvinq@nvidia.com>
Signed-off-by: M Q <mingmelvinq@nvidia.com>
…k examples Signed-off-by: M Q <mingmelvinq@nvidia.com>
Signed-off-by: M Q <mingmelvinq@nvidia.com>
Signed-off-by: M Q <mingmelvinq@nvidia.com>
mocsharp
reviewed
Jan 17, 2025
mocsharp
approved these changes
Jan 17, 2025
|
MMelQin
added a commit
that referenced
this pull request
Jan 23, 2025
…ure correct MD SDK is used in dev env (#516) * Add post intall action to patch holoscan package, v2.7 and 2.8 Signed-off-by: M Q <mingmelvinq@nvidia.com> * Update fixed turorials Signed-off-by: M Q <mingmelvinq@nvidia.com> * Updated the setup post install action, local sdk version, and notebook examples Signed-off-by: M Q <mingmelvinq@nvidia.com> * Updated the doc too Signed-off-by: M Q <mingmelvinq@nvidia.com> * Fix linting error Signed-off-by: M Q <mingmelvinq@nvidia.com> --------- Signed-off-by: M Q <mingmelvinq@nvidia.com>
MMelQin
added a commit
that referenced
this pull request
Jan 23, 2025
…a numpy array (#515) * Fix for case where input image is already a numpy array Signed-off-by: Chris Bridge <chrisbridge44@googlemail.com> * Update example apps' test data path, patch hsdk in local env, and ensure correct MD SDK is used in dev env (#516) * Add post intall action to patch holoscan package, v2.7 and 2.8 Signed-off-by: M Q <mingmelvinq@nvidia.com> * Update fixed turorials Signed-off-by: M Q <mingmelvinq@nvidia.com> * Updated the setup post install action, local sdk version, and notebook examples Signed-off-by: M Q <mingmelvinq@nvidia.com> * Updated the doc too Signed-off-by: M Q <mingmelvinq@nvidia.com> * Fix linting error Signed-off-by: M Q <mingmelvinq@nvidia.com> --------- Signed-off-by: M Q <mingmelvinq@nvidia.com> --------- Signed-off-by: Chris Bridge <chrisbridge44@googlemail.com> Signed-off-by: M Q <mingmelvinq@nvidia.com> Co-authored-by: Ming M Qin <38891913+MMelQin@users.noreply.github.com>
SimoneBendazzoli93
pushed a commit
to SimoneBendazzoli93/monai-deploy-app-sdk
that referenced
this pull request
Jun 26, 2025
…ure correct MD SDK is used in dev env (Project-MONAI#516) * Add post intall action to patch holoscan package, v2.7 and 2.8 Signed-off-by: M Q <mingmelvinq@nvidia.com> * Update fixed turorials Signed-off-by: M Q <mingmelvinq@nvidia.com> * Updated the setup post install action, local sdk version, and notebook examples Signed-off-by: M Q <mingmelvinq@nvidia.com> * Updated the doc too Signed-off-by: M Q <mingmelvinq@nvidia.com> * Fix linting error Signed-off-by: M Q <mingmelvinq@nvidia.com> --------- Signed-off-by: M Q <mingmelvinq@nvidia.com> Signed-off-by: Simone Bendazzoli <simben@kth.se>
SimoneBendazzoli93
pushed a commit
to SimoneBendazzoli93/monai-deploy-app-sdk
that referenced
this pull request
Jun 26, 2025
…a numpy array (Project-MONAI#515) * Fix for case where input image is already a numpy array Signed-off-by: Chris Bridge <chrisbridge44@googlemail.com> * Update example apps' test data path, patch hsdk in local env, and ensure correct MD SDK is used in dev env (Project-MONAI#516) * Add post intall action to patch holoscan package, v2.7 and 2.8 Signed-off-by: M Q <mingmelvinq@nvidia.com> * Update fixed turorials Signed-off-by: M Q <mingmelvinq@nvidia.com> * Updated the setup post install action, local sdk version, and notebook examples Signed-off-by: M Q <mingmelvinq@nvidia.com> * Updated the doc too Signed-off-by: M Q <mingmelvinq@nvidia.com> * Fix linting error Signed-off-by: M Q <mingmelvinq@nvidia.com> --------- Signed-off-by: M Q <mingmelvinq@nvidia.com> --------- Signed-off-by: Chris Bridge <chrisbridge44@googlemail.com> Signed-off-by: M Q <mingmelvinq@nvidia.com> Co-authored-by: Ming M Qin <38891913+MMelQin@users.noreply.github.com> Signed-off-by: Simone Bendazzoli <simben@kth.se>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to fix multiple issues reported lately.
Changed to use the _version.py generated on bumping version
holoscan==2.6.0
to the apps' requirements.txt file is the workaround