Skip to content

Commit 1a30bf1

Browse files
MMelQinSimoneBendazzoli93
authored andcommitted
Update example apps' test data path, patch hsdk in local env, and ensure correct MD SDK is used in dev env (Project-MONAI#516)
* Add post intall action to patch holoscan package, v2.7 and 2.8 Signed-off-by: M Q <mingmelvinq@nvidia.com> * Update fixed turorials Signed-off-by: M Q <mingmelvinq@nvidia.com> * Updated the setup post install action, local sdk version, and notebook examples Signed-off-by: M Q <mingmelvinq@nvidia.com> * Updated the doc too Signed-off-by: M Q <mingmelvinq@nvidia.com> * Fix linting error Signed-off-by: M Q <mingmelvinq@nvidia.com> --------- Signed-off-by: M Q <mingmelvinq@nvidia.com> Signed-off-by: Simone Bendazzoli <simben@kth.se>
1 parent bdd0e76 commit 1a30bf1

14 files changed

+3619
-4194
lines changed

docs/source/getting_started/tutorials/mednist_app.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,8 @@ jupyter-lab
5656

5757
## Executing from Shell
5858

59+
**_Note:_** Data files are now access controlled. Please first request permission to access the [shared folder on Google Drive](https://drive.google.com/drive/folders/1EONJsrwbGsS30td0hs8zl4WKjihew1Z3?usp=sharing). Please download zip file, `mednist_classifier_data.zip` in the `medmist_classifier_app` folder, to the same folder as the notebook example.
60+
5961
```bash
6062
# Clone the github project (the latest version of the main branch only)
6163
git clone --branch main --depth 1 https://github.com/Project-MONAI/monai-deploy-app-sdk.git
@@ -67,11 +69,8 @@ pip install monai-deploy-app-sdk
6769

6870
# Download/Extract mednist_classifier_data.zip from https://drive.google.com/file/d/1yJ4P-xMNEfN6lIOq_u6x1eMAq1_MJu-E/view?usp=sharing
6971

70-
# Download mednist_classifier_data.zip
71-
pip install gdown
72-
gdown https://drive.google.com/uc?id=1yJ4P-xMNEfN6lIOq_u6x1eMAq1_MJu-E
7372

74-
# After downloading mednist_classifier_data.zip from the web browser or using gdown
73+
# After having downloaded mednist_classifier_data.zip from the web browser or using gdown
7574
unzip -o mednist_classifier_data.zip
7675

7776
# Install necessary packages required by the app

docs/source/getting_started/tutorials/monai_bundle_app.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,8 @@ jupyter-lab
4646

4747
## Executing from Shell
4848

49+
**_Note:_** Data files are now access controlled. Please first request permission to access the [shared folder on Google Drive](https://drive.google.com/drive/folders/1EONJsrwbGsS30td0hs8zl4WKjihew1Z3?usp=sharing). Please download zip file, `mednist_classifieai_spleen_seg_bundle_data.zip` in the `ai_spleen_seg_app` folder, to the same folder as the notebook example.
50+
4951
```bash
5052
# Clone the github project (the latest version of main branch only)
5153
git clone --branch main --depth 1 https://github.com/Project-MONAI/monai-deploy-app-sdk.git
@@ -57,10 +59,7 @@ pip install --upgrade monai-deploy-app-sdk
5759

5860
# Download/Extract ai_spleen_bundle_data zip file from https://drive.google.com/file/d/1cJq0iQh_yzYIxVElSlVa141aEmHZADJh/view?usp=sharing
5961

60-
# Download the zip file containing both the model and test data
61-
pip install gdown
62-
gdown https://drive.google.com/uc?id=1Uds8mEvdGNYUuvFpTtCQ8gNU97bAPCaQ
63-
62+
# Download the zip file containing both the model and test data.
6463
# After downloading it using gdown, unzip the zip file saved by gdown and
6564
# copy the model file into a folder structure that is required by CLI Packager
6665
rm -rf dcm

docs/source/getting_started/tutorials/multi_model_app.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,8 @@ jupyter-lab
3434

3535
## Executing from Shell
3636

37+
**_Note:_** Data files are now access controlled. Please first request permission to access the [shared folder on Google Drive](https://drive.google.com/drive/folders/1EONJsrwbGsS30td0hs8zl4WKjihew1Z3?usp=sharing). Please download zip file, `ai_multi_model_bundle_data.zip` in the `ai_multi_ai_app` folder, to the same folder as the notebook example.
38+
3739
```bash
3840
# Clone the github project (the latest version of main branch only)
3941
git clone --branch main --depth 1 https://github.com/Project-MONAI/monai-deploy-app-sdk.git
@@ -43,10 +45,7 @@ cd monai-deploy-app-sdk
4345
# Install monai-deploy-app-sdk package
4446
pip install --upgrade monai-deploy-app-sdk
4547

46-
# Download the zip file containing both the model and test data
47-
pip install gdown
48-
gdown https://drive.google.com/uc?id=1llJ4NGNTjY187RLX4MtlmHYhfGxBNWmd
49-
48+
# Download the zip file containing both the model and test data.
5049
# After downloading it using gdown, unzip the zip file saved by gdown
5150
rm -rf dcm && rm -rf multi_models
5251
unzip -o ai_multi_model_bundle_data.zip

docs/source/getting_started/tutorials/segmentation_app.md

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,9 @@ jupyter-lab
3333
```
3434

3535
## Executing from Shell
36-
Please note that this part of the example uses the latest application source code on Github, as well as the corresponding test data.
36+
37+
**_Note:_** Data files are now access controlled. Please first request permission to access the [shared folder on Google Drive](https://drive.google.com/drive/folders/1EONJsrwbGsS30td0hs8zl4WKjihew1Z3?usp=sharing). Please download zip file, `ai_spleen_seg_bundle_data.zip` in the `ai_spleen_seg_app` folder, to the same folder as the notebook example.
38+
3739
```bash
3840
# Clone the github project (the latest version of main branch only)
3941
git clone --branch main --depth 1 https://github.com/Project-MONAI/monai-deploy-app-sdk.git
@@ -43,12 +45,7 @@ cd monai-deploy-app-sdk
4345
# Install monai-deploy-app-sdk package
4446
pip install --upgrade monai-deploy-app-sdk
4547

46-
# Download/Extract ai_spleen_bundle_data zip file from https://drive.google.com/file/d/1cJq0iQh_yzYIxVElSlVa141aEmHZADJh/view?usp=sharing
47-
48-
# Download the zip file containing both the model and test data
49-
pip install gdown
50-
gdown https://drive.google.com/uc?id=1Uds8mEvdGNYUuvFpTtCQ8gNU97bAPCaQ
51-
48+
# Download the zip file containing both the model and test data.
5249
# After downloading it using gdown, unzip the zip file saved by gdown and
5350
# copy the model file into a folder structure that is required by CLI Packager
5451
rm -rf dcm

0 commit comments

Comments
 (0)