-
Notifications
You must be signed in to change notification settings - Fork 3
refactor: non-primitive handling of witness data #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hratoanina
reviewed
Oct 14, 2025
4l0n50
reviewed
Oct 14, 2025
sai-deng
reviewed
Oct 15, 2025
LindaGuiga
reviewed
Oct 20, 2025
4l0n50
reviewed
Oct 21, 2025
…odular tables, align Op-based runners and MMCS trace builder, fix hash ops and executors.
sai-deng
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion we had highlighting the current issues of having to provide all necessary inputs for non-primitive ops to the
CircuitRunnerbefore the actual run, here's my attempt at simplifying the barrier betweenPrimitivevsNonPrimitiveops, as well as allowing a custom execution context for non-primitive ops to alleviate the issue above.For now the way we pass private witness data is unchanged, but this should also ease a transition towards automatic handling at runtime, so that users don't need to pre-generate specific data for each instance of their non-primitive ops.
Main changes:
PrimtoOpto reflect itExpr::NonPrimitiveOpis anOp::NonPrimitiveOpWithExecutor, which containsVec<ExprId>)Vec<ExprId>)ExprId(unlike the initial design not assigning any to non-primitive operations)executor, which defines custom logic specific to the operation to interact with the runner (so that it can get/set witnesses, execute its own internal logic and interact with private data (if needed))There is still more work to allow for proper dynamic dispatch at runtime with minimum disruption but this isn't the main goal of this PR so I'd rather hold off any other changes.