feat: allow dynamic dispatch of non-primitive tables #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nashtare
commented
Nov 6, 2025
Comment on lines
+70
to
+85
| /// Enables HashAbsorb operations. | ||
| pub fn enable_hash_absorb(&mut self, reset: bool) { | ||
| self.config.enable_hash_absorb(reset); | ||
| } | ||
|
|
||
| /// Enables HashSqueeze operations. | ||
| pub fn enable_hash_squeeze(&mut self) { | ||
| self.config.enable_hash_squeeze(); | ||
| } | ||
|
|
||
| /// Enables hash operations. | ||
| pub fn enable_hash(&mut self, reset: bool) { | ||
| self.enable_hash_absorb(reset); | ||
| self.enable_hash_squeeze(); | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Technically unrelated but I noticed these missing. I haven't kept track of the latest discussions around hashing handling so can remove these changes if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complements #150 in allowing true dynamic handling of non-primitive operations at runtime, as opposed to the current prover which still hardcodes tables to be proven like MMCS.
List of changes:
TableProvertrait with degree-specific methods: this one is a bit cumbersome, because we have to a distinction between degrees because of type-safety. I added a macro for easier handling so that we only need to specify the base case without worrying about extension ones.