-
Notifications
You must be signed in to change notification settings - Fork 16
Add Navbar to Documentation Pages for All Releases After "Latest Code Documentation" #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@dlebauer Looking forward to your response. Thanks in advance! |
thanks for this change! Could you please resolve conflicts in documentation.js? https://github.com/PecanProject/PecanProject.github.io/pull/83/conflicts |
@dlebauer Okey, I'll resolve it soon. |
@dlebauer solved the conflict in the documentation.js click here to review. |
@divine7022 thanks for doing this, though I am not sure I fully understand - it looks like, compared to this PR, #89 just changes urls to relative paths? Would it make sense to change the base branch of 89 so that it is proposing changes to divine7022:fix-bug? (see https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-base-branch-of-a-pull-request) I went ahead and resolved the conflicts on this branch since it seemed clear that the intent was to add the Documentation() function FYI in case this wasn't clear - here are GitHub docs resolving conflicts in GitHub. Thanks again for your help with this! |
@dlebauer Thanks for your valuable feedback! |
@divine7022 sorry, should I still merge both? Also, this one has a failed build after resolving conflicts |
@dlebauer No worries! Thanks for your review! |
Fixed: #82
This PR adds a navbar to the documentation pages for all releases listed after "Latest Code Documentation." Previousl , these versioned documentation pages did not have a navbar, making navigation inconsistent. This update ensures that users can easily switch between different documentation versions without relying on external links or manual navigation.
Befor:

After:

Let me know if you need any modifications! 🚀
Looking forward to your( @dlebauer ) response. Thanks in advance!