Jinja generation: add protection against accidental overwriting #682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checks against overwriting manual changes and against overwriting the template itself
Jaeyoung-Lim
requested changes
Dec 30, 2020
|
Hi @Jaeyoung-Lim, What is the recommended way to reproduce the Github workflows / build locally? In the meantime, I changed what I think is the cause of the build failure. |
Jaeyoung-Lim
approved these changes
Dec 31, 2020
RyosukeMatsushima
pushed a commit
to RyosukeMatsushima/PX4-SITL_gazebo
that referenced
this pull request
Jun 21, 2022
) * Jinja generation: add protection against accidental overwriting Checks against overwriting manual changes and against overwriting the template itself * Support Python 3.5 * Overwrite protection: ignore leading and trailing whitespace Co-authored-by: Pieter-Jan Dewitte <pieterjan.dewitte@atmosuav.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks against overwriting manual changes and against overwriting the template itself.
I'm aware of the pull request #651. It seems the changes are compatible, but they won't merge automatically.
Let me know if you have any feedback.