Skip to content

Conversation

amovlgf
Copy link
Contributor

@amovlgf amovlgf commented May 27, 2025

Dear developer, I would like to apply for a board ID for our flight control product. Please review it.

@hamishwillee hamishwillee requested a review from mrpollo May 28, 2025 00:22
@hamishwillee
Copy link

@mrpollo I don't know who owns this repo and should review this. Have assigned you. If there is some other "default" person to select then let me know.

Copy link
Member

@davids5 davids5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amovlgf 60 is already in use. as you can see from

find . -name firmware.prototype | xargs grep board_id | grep 60

./boards/auterion/fmu-v6s/firmware.prototype: "board_id": 60,
(@niklaut please do a pr for it)

@amovlgf You should pick a value for the board_id in the range 100-999 that is not used.

chack the list it the txt file and use find . -name firmware.prototype | xargs grep board_id | grep <Canidate ID>

@amovlgf
Copy link
Contributor Author

amovlgf commented May 28, 2025

@amovlgf 60 is already in use. as you can see from

find . -name firmware.prototype | xargs grep board_id | grep 60

./boards/auterion/fmu-v6s/firmware.prototype: "board_id": 60, (@niklaut please do a pr for it)

@amovlgf You should pick a value for the board_id in the range 100-999 that is not used.

chack the list it the txt file and use find . -name firmware.prototype | xargs grep board_id | grep <Canidate ID>

Thank you for your reminder. I have changed the ID to 106. I checked and found that 106 is not occupied. Please review it.

@davids5 davids5 merged commit 2f953db into PX4:main May 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants