Skip to content

[Bug] MAVLink Commands dont report support status #24696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hamishwillee opened this issue Apr 9, 2025 · 1 comment
Open

[Bug] MAVLink Commands dont report support status #24696

hamishwillee opened this issue Apr 9, 2025 · 1 comment

Comments

@hamishwillee
Copy link
Contributor

Describe the bug

MAVLink commands are supposed to always ACK a response. PX4 returns no ACK for the following commands when sent to Gazebo in the current head revision of main.
This matters because the recipients are expecting a result - and will assume failure and resend if not.

I suspect that in some cases, such as the camera and gimbal, the commands are handled by the camera driver or gimbal manager when enabled. But if not enabled the command is swallowed without a response. Similar thing might be happening for payload etc.

'MAV_CMD_DO_FIGURE_EIGHT',
'MAV_CMD_NAV_DELAY',
'MAV_CMD_DO_DIGICAM_CONTROL',
'MAV_CMD_DO_MOUNT_CONFIGURE',
'MAV_CMD_DO_MOUNT_CONTROL',
'MAV_CMD_DO_SET_CAM_TRIGG_DIST',
'MAV_CMD_DO_GRIPPER',
'MAV_CMD_DO_SET_CAM_TRIGG_INTERVAL',
'MAV_CMD_DO_MOUNT_CONTROL_QUAT',
'MAV_CMD_PREFLIGHT_SET_SENSOR_OFFSETS',
'MAV_CMD_PREFLIGHT_UAVCAN',
'MAV_CMD_OBLIQUE_SURVEY',
'MAV_CMD_ACTUATOR_TEST',
'MAV_CMD_CONFIGURE_ACTUATOR',
'MAV_CMD_INJECT_FAILURE',
'MAV_CMD_START_RX_PAIR',
'MAV_CMD_REQUEST_CAMERA_INFORMATION',
'MAV_CMD_SET_CAMERA_MODE',
'MAV_CMD_SET_CAMERA_ZOOM',
'MAV_CMD_SET_CAMERA_FOCUS',
'MAV_CMD_DO_GIMBAL_MANAGER_PITCHYAW',
'MAV_CMD_DO_GIMBAL_MANAGER_CONFIGURE',
'MAV_CMD_DO_TRIGGER_CONTROL',
'MAV_CMD_DO_VTOL_TRANSITION',
'MAV_CMD_PAYLOAD_PREPARE_DEPLOY',
'MAV_CMD_PAYLOAD_CONTROL_DEPLOY',
'MAV_CMD_DO_WINCH'],

To Reproduce

I used a test script that fires every command in development.xml and below at SITL. This is not easily sharable because it is a work in progress fun test project based on libmav-python.

You could similarly test with pymavlink.

Expected behavior

A COMMAND_ACK with some command value should be sent in response to every command.

Screenshot / Media

No response

Flight Log

No response

Software Version

Gazebo SITL and PX4 main

Flight controller

No response

Vehicle type

Multicopter

How are the different components wired up (including port information)

No response

Additional context

No response

@hamishwillee
Copy link
Contributor Author

FYI @julianoes YOu might want to look at the camera/gimbal ones of these.

@github-actions github-actions bot added the stale label May 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant