Weekly Digest (3 March, 2019 - 10 March, 2019)

[weekly-digest]

Here's the Weekly Digest for PX4/Firmware:

---

ISSUES

Last week 37 issues were created.
Of these, 18 issues have been closed and 19 issues are still open.

OPEN ISSUES

💚 #11613 error [unknown] warning! time is negative!, by docHell
💚 #11612 Deprecate _hil_frames and _old_timestamp member vars and dead logic from MavlinkReceiver class - (Break apart PR#11274 into easily verifiable steps - Step 6), by mcsauder
💚 #11611 Alphabetize a few methods and variable orders in mavlink_receiver.h - (Break apart PR#11274 into easily verifiable steps - Step 5), by mcsauder
💚 #11605 Log EKF output from initialization, by CarlOlsson
💚 #11604 High CPU load on Pixhawk 4 (fmu-v5), by DanielePettenuzzo
💚 #11602 Support roll, pitch, thrust and yaw rate in OFFBOARD, by ajshank
💚 #11600 Problem sending command long, by garfieldG
💚 #11599 Landing airspeed, by ryanjAA
💚 #11595 VotedSensorsUpdate::check_failover seems to misinterpret simultaneous failures, by tstellanova
💚 #11592 Pr ground effect zone, by EliaTarasov
💚 #11591 mavlink forward question, by ToppingXu
💚 #11590 Intel aero platform error, by limhyon
💚 #11589 Unable to access to udp port, by docHell
💚 #11588 Must reboot Pixhawk Between Missions, by ryanjAA
💚 #11586 FW idle rpm after arming too high, by MiguelSpare
💚 #11584 Bug: arm in manual sometimes not possible if GPS quality is low, by AuterionWrikeBot
💚 #11583 Bug: velocity setpoint goes out of 0 during hovering with smooth position control in manual pos control, by AuterionWrikeBot
💚 #11582 [WIP] Set all parameters objects on mc_pos_control to be with the convation, by BazookaJoe1900
💚 #11581 compile error:No such file or directory: '.../Firmware/src/drivers/uavcan/libuavcan/libuavcan/../dsdl/uavcan', by AlexLuya

CLOSED ISSUES

❤️ #11610 Migrate a few more var initializations from the Mavlink class constructor list to declarations., by mcsauder
❤️ #11609 Jenkins update SITL tests coverage to correct base container, by dagar
❤️ #11608 Whitespace formatting in mavlink_main.cpp/h and begin migrating variable initialization., by mcsauder
❤️ #11607 cmake nuttx set CMP0079 policy, by dagar
❤️ #11606 jenkins: update all image tags to 2019-03-08, by lamping7
❤️ #11603 Jenkins add SITL tests AddressSanitizer, by dagar
❤️ #11601 Lockstep scheduler: shutdown fixes / work-arounds, by bkueng
❤️ #11598 SITL, Model: plane, [Err] [gazebo_mavlink_interface.cpp:1166] Error opening serial device: open: No such file or directory, by libi95
❤️ #11597 Update submodule jMAVSim to latest Wed Mar 6 00:38:35 UTC 2019, by dagar
❤️ #11596 Update submodule mavlink v2.0 to latest Wed Mar 6 00:38:42 UTC 2019, by dagar
❤️ #11594 ekf2 update setGpsData usage, by dagar
❤️ #11593 Complete Simulator class mavlink handle_message_XXX() method implementations., by mcsauder
❤️ #11587 RTL fix RTL_TYPE param metadata group, by dagar
❤️ #11585 Type of file airframe + error when building code UnicodeEncodeError: 'ascii' codec can't encode character '\xea' in position 38: ordinal not in range(128), by guroz
❤️ #11580 Delete unnecessary #includes from mavlink_main.cpp and relocate two #defines to mavlink_main.h, by mcsauder
❤️ #11579 CONTRIBUTING:Fix up code.html link to goto master, by hamishwillee
❤️ #11578 Cannot build code: make: *** [px4_fmu-v3_default] Error 1, by guroz
❤️ #11576 navigator fix FW loiter tangent exit, by dagar

NOISY ISSUE

🔈 #11576 navigator fix FW loiter tangent exit, by dagar
It received 14 comments.

---

PULL REQUESTS

Last week, 50 pull requests were created, updated or merged.

UPDATED PULL REQUEST

Last week, 28 pull requests were updated.
💛 #11612 Deprecate _hil_frames and _old_timestamp member vars and dead logic from MavlinkReceiver class - (Break apart PR#11274 into easily verifiable steps - Step 6), by mcsauder
💛 #11611 Alphabetize a few methods and variable orders in mavlink_receiver.h - (Break apart PR#11274 into easily verifiable steps - Step 5), by mcsauder
💛 #11592 Pr ground effect zone, by EliaTarasov
💛 #11574 containers add Queue and testing, by dagar
💛 #11573 Enable convenient unit testing using googletest on POSIX, by MaEtUgR
💛 #11570 PX4 general work queue, by dagar
💛 #11561 Smooth avoidance output, by mrivi
💛 #11550 [WIP] Commander datalinks lost failsafe handing, by cmic0
💛 #11540 Reintroduce slow down when landing manually, by MaEtUgR
💛 #11537 NuttX update to current master, by dagar
💛 #11489 [WIP] uORB: add px4 work queue call back mechanism on publish, by dagar
💛 #11454 [WIP] HEARTBEAT and commander failsafe handling cleanup, by dagar
💛 #11431 Add mavlink play tune message to simulator class, by catch-twenty-two
💛 #11400 simulator in hardware, new module, by romain-chiap
💛 #11394 [READY FOR test] Add f7 bl update, by davids5
💛 #11365 Fix: ROS install space, by TSC21
💛 #11351 [WIP Do not merge] NXP i.MXRT port of PX4 FMUv5, by davids5
💛 #11308 Modularize Attitude Control, by MaEtUgR
💛 #11274 Variable initialization moved from constructor to declarations in MavlinkReceiver class and alphabetize var lists., by mcsauder
💛 #11267 [Breaking Change]fmuk66-v3: Only Support Rev BX11, by davids5
💛 #11224 Adis16448 refactor, by mcsauder
💛 #11092 EKF2: add usage to new exposed covariance, by TSC21
💛 #10892 RPYrT Support. Format checked., by Pedro-Roque
💛 #10883 weathervane: added configuration option via paramter, by RomanBapst
💛 #10780 Avoidance Interface CI, by mrivi
💛 #10320 [WIP] Make DO_SET_SERVO work, by kpetrykin
💛 #10179 Failure detector / Failsafe (Parachute) triggering, by bresch
💛 #9756 [WIP] introduce new vehicle_imu message, by dagar

MERGED PULL REQUEST

Last week, 22 pull requests were merged.
💜 #11610 Migrate a few more var initializations from the Mavlink class constructor list to declarations., by mcsauder
💜 #11609 Jenkins update SITL tests coverage to correct base container, by dagar
💜 #11608 Whitespace formatting in mavlink_main.cpp/h and begin migrating variable initialization., by mcsauder
💜 #11606 jenkins: update all image tags to 2019-03-08, by lamping7
💜 #11603 Jenkins add SITL tests AddressSanitizer, by dagar
💜 #11601 Lockstep scheduler: shutdown fixes / work-arounds, by bkueng
💜 #11597 Update submodule jMAVSim to latest Wed Mar 6 00:38:35 UTC 2019, by dagar
💜 #11596 Update submodule mavlink v2.0 to latest Wed Mar 6 00:38:42 UTC 2019, by dagar
💜 #11594 ekf2 update setGpsData usage, by dagar
💜 #11593 Complete Simulator class mavlink handle_message_XXX() method implementations., by mcsauder
💜 #11587 RTL fix RTL_TYPE param metadata group, by dagar
💜 #11580 Delete unnecessary #includes from mavlink_main.cpp and relocate two #defines to mavlink_main.h, by mcsauder
💜 #11579 CONTRIBUTING:Fix up code.html link to goto master, by hamishwillee
💜 #11576 navigator fix FW loiter tangent exit, by dagar
💜 #11572 Format and edit a few comments in mavlink_receiver.h. - (Break apart PR#11274 into easily verifiable steps - Step 4) , by mcsauder
💜 #11566 Fix link to code style guide, by mortenfyhn
💜 #11565 simulator: fix to set system and component IDs as defined in params, by gamoreno
💜 #11564 Redefine Simulator::handle_message() prototype and create Simulator::set_publish() method., by mcsauder
💜 #11545 ekf2: Split static pressure correction into separate RH and LH ellipsoids, by priseborough
💜 #11465 Jenkins re-enable Catkin and Colcon builds, by dagar
💜 #11338 CI: SITL test run: select ROS version based on ROS_DISTRO, by lamping7
💜 #11140 [WIP] QMC5883 Magnetometer Driver, by dlwalter

---

COMMITS

Last week there were 34 commits.
🛠️ CI: SITL test run: select ROS version based on env variable by lamping7
🛠️ Jenkins re-enable Catkin and Colcon builds by dagar
🛠️ Migrate a few more var initializations from the Mavlink class constructor list to the respective declarations. by mcsauder
🛠️ Whitespace formatting in mavlink_main.cpp/h and begin work of some variable initialization at declaration in mavlink_main.h. by mcsauder
🛠️ Jenkins update SITL tests coverage to correct base container by dagar
🛠️ jenkins: update all image tags to 2019-03-08 by lamping7
🛠️ Delete unnecessary #includes from mavlink_main.cpp and relocate a few #defines to mavlink_main.h for future variable initialization work. by mcsauder
🛠️ QMC5883 Magnetometer Driver (#11140) by dlwalter
🛠️ lockstep_scheduler: work around a potential dead-lock for canceled threads by bkueng
🛠️ lockstep_scheduler: fix system_sleep -> system_usleep The effect was that threads that tried to exit were unnecessarily kept running. This did not cause problems except for increased resource usage. by bkueng
🛠️ drv_hrt: make lockstep_scheduler a pointer This solves a potential dead-lock when trying to shutdown: a call to exit() stops all threads and calls all destructors for static objects. The destructor of LockstepScheduler takes a lock. However this is not safe, as the lock could already be taken (by any thread). by bkueng
🛠️ Jenkins add SITL tests AddressSanitizer by dagar
🛠️ Add const specifier to remaining methods utilizing mavlink_message_t and similar message pointer types. by mcsauder
🛠️ Cut case MAVLINK_MSG_ID_ODOMETRY content and paste into handle_message_odometry() method. by mcsauder
🛠️ Cut case MAVLINK_MSG_ID_VISION_POSITION_ESTIMATE content and paste into handle_message_vision_position_estimate() method. Add const specifier to publish_odometry_topic() method. by mcsauder
🛠️ Delete unnecessary curly braces in simulator_mavlink.cpp by mcsauder
🛠️ Cut case MAVLINK_MSG_ID_RC_CHANNELS content and paste into handle_message_rc_channels() method. by mcsauder
🛠️ Cut case MAVLINK_MSG_ID_HIL_GPS content and paste into handle_message_hil_gps() method. by mcsauder
🛠️ Cut case MAVLINK_MSG_ID_HIL_SENSOR content and paste into handle_message_hil_sensor() method. by mcsauder
🛠️ [Update submodule jMAVSim to latest Wed Mar 6 00:38:35 UTC 2019 (#11597) - jMAVSim in PX4/Firmware (a97151f): https://github.com/PX4/jMAVSim/commit/0c25b7c18990a64fc851cfd7fe3aac9a4060aea3
- jMAVSim current upstream: https://github.com/PX4/jMAVSim/commit/8b2f4568e05935af57782fd0db9a434f733cc800
- Changes: https://github.com/PX4/jMAVSim/compare/0c25b7c18990a64fc851cfd7fe3aac9a4060aea3...8b2f4568e05935af57782fd0db9a434f733cc800

 8b2f456 2019-02-28 Julian Oes - Merge pull request #95 from PX4/shell-style

3d0174a 2019-02-27 Matthias Grob - Fix shell script style](37cda4e) by dagar
🛠️ [Update submodule mavlink v2.0 to latest Wed Mar 6 00:38:42 UTC 2019 (#11596) - mavlink v2.0 in PX4/Firmware (1a2b88e): https://github.com/mavlink/c_library_v2/commit/f073569b746b6533c1715b0bbfed6c988444b257
- mavlink v2.0 current upstream: https://github.com/mavlink/c_library_v2/commit/2a47f11e73eef6d817af7934692b1223d7fb434f
- Changes: https://github.com/mavlink/c_library_v2/compare/f073569b746b6533c1715b0bbfed6c988444b257...2a47f11e73eef6d817af7934692b1223d7fb434f

 2a47f11 2019-03-01 PX4BuildBot - autogenerated headers for rev https://github.com/mavlink/mavlink/tree/747c3e73e9ad28e8011cdc5c98faf56752b1d32a](https://github.com/PX4/Firmware/commit/a01b59869451dbdac48797698ea5e351f42716cb) by [dagar](https://github.com/dagar)

🛠️ ekf2 update setGpsData usage by dagar
🛠️ Set default set_publlish() argument to true. by mcsauder
🛠️ Refactor set_publish() logic so that a default false value is not (re)set each loop in simulator_mapvlink.cpp and provide a default argument to set_publish() in simulator.h. by mcsauder
🛠️ Create Simulator::set_publish() method and Simulator::_publish member variable to allow redefinition of the Simulator::handle_message() prototype to match MavlinkReceiver::handle_message(). by mcsauder
🛠️ RTL fix RTL_TYPE param metadata group by dagar
🛠️ ekf2: Minor parameter description edits by priseborough
🛠️ ekf2: style fixes by priseborough
🛠️ ekf2: Split static pressure correction into separate RH ad LH ellipsoids by priseborough
🛠️ CONTRIBUTING:Fix up code.html link to goto master by hamishwillee
🛠️ navigator fix FW loiter to alt tangent exit (#11576) - fixes #11317 by dagar
🛠️ simulator: fix to set system and component IDs as defined in params The simulator had hardcoded component ID and system ID (sysID was 0), ignoring what was set up in the params MAV_SYS_ID and MAV_COMP_ID. This caused an issue with multi-vehicle simulations that that rely on sysID to identify the vehicles. Signed-off-by: Gabriel Moreno gabrielm@cs.cmu.edu by gamoreno
🛠️ Fix link to code style guide In CONTRIBUTING.md, the current link to the coding style leads to a 404 error. I've replaced it with a link to the Source Code Management part of the developer documentation, which is where the style guide seems to be now. by mortenfyhn
🛠️ Formatted and edited a few comments in mavlink_receiver.h. by mcsauder

---

CONTRIBUTORS

Last week there were 9 contributors.
👤 lamping7
👤 dagar
👤 mcsauder
👤 dlwalter
👤 bkueng
👤 priseborough
👤 hamishwillee
👤 gamoreno
👤 mortenfyhn

---

STARGAZERS

Last week there were 13 stagazers.
⭐ 787674247
⭐ merturk
⭐ Jaeyoung-Lim
⭐ netpower
⭐ miseon119
⭐ langyo
⭐ chuanjin
⭐ deoxal
⭐ geoffreyvd
⭐ Daveads
⭐ caomxin
⭐ JacobJones001
⭐ Ncerzzk
You all are the stars! 🌟

---

RELEASES

Last week there were no releases.

---

That's all for last week, please 👀 Watch and ⭐ Star the repository PX4/Firmware to receive next weekly updates. 😃

You can also view all Weekly Digests by clicking here.

Your Weekly Digest bot. 📆