Skip to content

Mission Protocol does not properly handle cancelation #11183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hamishwillee opened this issue Jan 9, 2019 · 1 comment
Open

Mission Protocol does not properly handle cancelation #11183

hamishwillee opened this issue Jan 9, 2019 · 1 comment
Labels
Admin: Enhancement (improvement) 💡 Admin: Pinned Communication (MAVLink) 📡

Comments

@hamishwillee
Copy link
Contributor

hamishwillee commented Jan 9, 2019 •
edited by AuterionWrikeBot
Loading

The only way (currently) supported by MAVLink to cancel a mission is to NACK a message (MISSION_ACK) with an error. Currently if there is an error the system will report a critical error.

The required change is that MAV_MISSION_OPERATION_CANCELLED ack is received PX4 should not emit a critical error (it might emit some other notification, but this case is "OK", not an error).

FYI The MAV_MISSION_OPERATION_CANCELLED was added by mavlink/mavlink#1044 . Docs will be added to MAVLink spec by mavlink/mavlink-devguide#157

@julianoes FYI
@stale stale bot removed the Admin: Wont fix label Oct 1, 2019
@hamishwillee
Copy link
Contributor Author

@julianoes I have pinned. We probably do need to fix this though.

@PX4 PX4 deleted a comment from stale bot Oct 1, 2019
@PX4 PX4 deleted a comment from stale bot Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Admin: Enhancement (improvement) 💡 Admin: Pinned Communication (MAVLink) 📡
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@julianoes @hamishwillee