Skip to content

Upgrade Spomky webauthn dependencies #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2025
Merged

Upgrade Spomky webauthn dependencies #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 35 additions & 20 deletions ci/qa/phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,42 +41,37 @@ parameters:
path: ../../dev/Controller/SPController.php

-
message: "#^Parameter \\#2 \\$allowCredentials of method Webauthn\\\\Bundle\\\\Service\\\\PublicKeyCredentialRequestOptionsFactory\\:\\:create\\(\\) expects array\\<Webauthn\\\\PublicKeyCredentialDescriptor\\>, array\\<Surfnet\\\\Webauthn\\\\Entity\\\\PublicKeyCredentialSource\\> given\\.$#"
message: "#^Parameter \\#1 \\$publicKeyCredentialUserEntity of method Surfnet\\\\Webauthn\\\\Repository\\\\PublicKeyCredentialSourceRepository\\:\\:findAllForUserEntity\\(\\) expects Webauthn\\\\PublicKeyCredentialUserEntity, Webauthn\\\\PublicKeyCredentialUserEntity\\|null given\\.$#"
count: 1
path: ../../src/Controller/AuthenticationController.php

-
message: "#^Method Surfnet\\\\Webauthn\\\\Controller\\\\ExceptionController\\:\\:getPageTitleAndDescription\\(\\) return type has no value type specified in iterable type array\\.$#"
count: 1
path: ../../src/Controller/ExceptionController.php

-
message: "#^Property Surfnet\\\\Webauthn\\\\Entity\\\\PublicKeyCredentialSource\\:\\:\\$id is unused\\.$#"
message: "#^Parameter \\#2 \\$allowCredentials of method Webauthn\\\\Bundle\\\\Service\\\\PublicKeyCredentialRequestOptionsFactory\\:\\:create\\(\\) expects array\\<Webauthn\\\\PublicKeyCredentialDescriptor\\>, array\\<Webauthn\\\\PublicKeyCredentialSource\\> given\\.$#"
count: 1
path: ../../src/Entity/PublicKeyCredentialSource.php
path: ../../src/Controller/AuthenticationController.php

-
message: "#^Class Surfnet\\\\Webauthn\\\\Entity\\\\User has an uninitialized readonly property \\$id\\. Assign it in the constructor\\.$#"
message: "#^Method Surfnet\\\\Webauthn\\\\Controller\\\\ExceptionController\\:\\:getPageTitleAndDescription\\(\\) return type has no value type specified in iterable type array\\.$#"
count: 1
path: ../../src/Entity/User.php
path: ../../src/Controller/ExceptionController.php

-
message: "#^Class Surfnet\\\\Webauthn\\\\Entity\\\\User has an uninitialized readonly property \\$name\\. Assign it in the constructor\\.$#"
message: "#^Property Surfnet\\\\Webauthn\\\\Entity\\\\PublicKeyCredentialSource\\:\\:\\$fmt is never read, only written\\.$#"
count: 1
path: ../../src/Entity/User.php
path: ../../src/Entity/PublicKeyCredentialSource.php

-
message: "#^Method Surfnet\\\\Webauthn\\\\Entity\\\\User\\:\\:getPublicKeyCredentialSources\\(\\) should return array\\<Webauthn\\\\PublicKeyCredentialSource\\> but returns array\\<int, mixed\\>\\.$#"
message: "#^Class Surfnet\\\\Webauthn\\\\Entity\\\\User has an uninitialized readonly property \\$displayName\\. Assign it in the constructor\\.$#"
count: 1
path: ../../src/Entity/User.php

-
message: "#^Parameter \\$repositoryClass of attribute class Doctrine\\\\ORM\\\\Mapping\\\\Entity constructor expects class\\-string\\<Doctrine\\\\ORM\\\\EntityRepository\\<T of object\\>\\>\\|null, 'Surfnet\\\\\\\\Webauthn\\\\\\\\Repository\\\\\\\\UserRepository' given\\.$#"
message: "#^Class Surfnet\\\\Webauthn\\\\Entity\\\\User has an uninitialized readonly property \\$id\\. Assign it in the constructor\\.$#"
count: 1
path: ../../src/Entity/User.php

-
message: "#^Property Surfnet\\\\Webauthn\\\\Entity\\\\User\\:\\:\\$publicKeyCredentialSources with generic interface Doctrine\\\\Common\\\\Collections\\\\Collection does not specify its types\\: TKey, T$#"
message: "#^Class Surfnet\\\\Webauthn\\\\Entity\\\\User has an uninitialized readonly property \\$name\\. Assign it in the constructor\\.$#"
count: 1
path: ../../src/Entity/User.php

Expand All @@ -100,6 +95,16 @@ parameters:
count: 1
path: ../../src/GlobalViewParameters.php

-
message: "#^Parameter \\#1 \\$data of function unserialize expects string, mixed given\\.$#"
count: 2
path: ../../src/Migrations/Version20250213135649.php

-
message: "#^Part \\$id \\(mixed\\) of encapsed string cannot be cast to string\\.$#"
count: 1
path: ../../src/Migrations/Version20250213135649.php

-
message: "#^Method Surfnet\\\\Webauthn\\\\PublicKeyCredentialCreationOptionsStore\\:\\:get\\(\\) should return Webauthn\\\\PublicKeyCredentialCreationOptions but returns mixed\\.$#"
count: 1
Expand All @@ -111,17 +116,17 @@ parameters:
path: ../../src/PublicKeyCredentialRequestOptionsStore.php

-
message: "#^Method Surfnet\\\\Webauthn\\\\Repository\\\\PublicKeyCredentialSourceRepository\\:\\:allForUser\\(\\) should return array\\<Surfnet\\\\Webauthn\\\\Entity\\\\PublicKeyCredentialSource\\> but returns mixed\\.$#"
message: "#^Method Surfnet\\\\Webauthn\\\\Repository\\\\PublicKeyCredentialSourceRepository\\:\\:findAllForUserEntity\\(\\) should return array\\<Webauthn\\\\PublicKeyCredentialSource\\> but returns mixed\\.$#"
count: 1
path: ../../src/Repository/PublicKeyCredentialSourceRepository.php

-
message: "#^Parameter \\#7 \\$credentialPublicKey of class Surfnet\\\\Webauthn\\\\Entity\\\\PublicKeyCredentialSource constructor expects string, string\\|null given\\.$#"
message: "#^Call to function is_null\\(\\) with Doctrine\\\\ORM\\\\EntityManagerInterface will always evaluate to false\\.$#"
count: 1
path: ../../src/Repository/PublicKeyCredentialSourceRepository.php
path: ../../src/Repository/UserRepository.php

-
message: "#^Call to function is_null\\(\\) with Doctrine\\\\ORM\\\\EntityManagerInterface will always evaluate to false\\.$#"
message: "#^Class Surfnet\\\\Webauthn\\\\Repository\\\\UserRepository extends generic class Doctrine\\\\Bundle\\\\DoctrineBundle\\\\Repository\\\\ServiceEntityRepository but does not specify its types\\: T$#"
count: 1
path: ../../src/Repository/UserRepository.php

Expand All @@ -136,10 +141,20 @@ parameters:
path: ../../src/Repository/UserRepository.php

-
message: "#^Method Surfnet\\\\Webauthn\\\\Repository\\\\UserRepository\\:\\:getByUserId\\(\\) should return Surfnet\\\\Webauthn\\\\Entity\\\\User but returns Surfnet\\\\Webauthn\\\\Entity\\\\User\\|null\\.$#"
message: "#^Parameter \\#1 \\$name of class Surfnet\\\\Webauthn\\\\Entity\\\\User constructor expects string, string\\|null given\\.$#"
count: 1
path: ../../src/Repository/UserRepository.php

-
message: "#^Parameter \\#3 \\$displayName of class Surfnet\\\\Webauthn\\\\Entity\\\\User constructor expects string, string\\|null given\\.$#"
count: 1
path: ../../src/Repository/UserRepository.php

-
message: "#^Access to an undefined property Symfony\\\\Component\\\\Security\\\\Core\\\\User\\\\UserInterface\\:\\:\\$id\\.$#"
count: 1
path: ../../src/Security/AuthenticationListener.php

-
message: "#^Method Surfnet\\\\Webauthn\\\\Service\\\\ClientMetadataService\\:\\:generateMetadata\\(\\) return type has no value type specified in iterable type array\\.$#"
count: 1
Expand Down
6 changes: 3 additions & 3 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,9 @@
"symfony/yaml": "^6.4",
"twig/twig": "^3.8",
"web-auth/cose-lib": "^4.4",
"web-auth/webauthn-lib": "^4.9",
"web-auth/webauthn-stimulus": "^4.9",
"web-auth/webauthn-symfony-bundle": "^4.9",
"web-auth/webauthn-lib": "^5.1",
"web-auth/webauthn-stimulus": "^5.1",
"web-auth/webauthn-symfony-bundle": "^5.1",
"web-token/jwt-signature-algorithm-rsa": "^3.4"
},
"require-dev": {
Expand Down
Loading