Skip to content

Upgrade Spomky webauthn dependencies #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

pablothedude
Copy link
Contributor

@pablothedude pablothedude commented Feb 14, 2025

Also removed the custom internal controller logic.
So when the Webauthn flow is started it will be
completely handled by the bundle and the configuration
can be used without hassle.

@pablothedude pablothedude marked this pull request as draft February 14, 2025 16:36
@pablothedude pablothedude force-pushed the feature/upgrade-webauthn-library branch 6 times, most recently from 76d410a to ea71576 Compare February 21, 2025 16:02
@pablothedude pablothedude force-pushed the feature/upgrade-webauthn-library branch 2 times, most recently from f84595d to aca0dea Compare February 24, 2025 15:03
@pablothedude pablothedude marked this pull request as ready for review February 24, 2025 15:07
@pablothedude pablothedude requested a review from johanib February 24, 2025 15:07
@pablothedude pablothedude force-pushed the feature/upgrade-webauthn-library branch 2 times, most recently from bddad77 to 86bccd5 Compare March 3, 2025 11:43
@pablothedude pablothedude requested a review from johanib March 3, 2025 11:43
Copy link
Contributor

@johanib johanib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@pablothedude pablothedude force-pushed the feature/upgrade-webauthn-library branch 2 times, most recently from 52df15a to b6438f1 Compare March 3, 2025 14:08
Also removed the custom internal controller logic.
So when the Webauthn flow is started it will be
completely handled by the bundle and the configuration
can be used without hassle.
@pablothedude pablothedude force-pushed the feature/upgrade-webauthn-library branch from b6438f1 to b526933 Compare March 3, 2025 14:18
@pablothedude pablothedude merged commit 666df28 into main Mar 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants