Add a deserialized Data Validator #6770
Open
+50
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This part of code is really needed in my opinion for anyone wanting to take a JSON deserialize it and validate it.
|
cc PHP technical committee @jebentier, @dkarlovi, @mandrean, @jfastnacht, @ackintosh, @renepardon |
dkarlovi
suggested changes
Oct 22, 2020
| * @param mided $data object to be validated | ||
| * @throws \InvalidArgumentException | ||
| */ | ||
| public static function verifyDeserializedData ($data) { |
There was a problem hiding this comment.
Not sure about the design here: the data needs to be valid enough for the deserialization to take place. If that already happened, ObjectSerializer has nothing to do with it.
| @@ -339,4 +339,29 @@ class ObjectSerializer | |||
| return $instance; | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * Verify the Data structure to make sure all the objects are validated | |||
There was a problem hiding this comment.
Code seems to be using tabs? Spaces are used elsewhere.
| } | ||
|
|
||
| } | ||
| else if (is_array ($data)) { |
There was a problem hiding this comment.
Inline with previous closing brace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This part of code is really needed in my opinion for anyone wanting to take a JSON deserialize it and validate it.