Update ObjectSerializer.mustache #6769
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we deserialize a json structure, only the first level of validation is done and accessible with "listInvalidProperties" To validate all sub objects, everyone would need to loop again on the objects and follow all properties, check if they are objects and call listInvalidProperties on each of them. A better approach would be to have the "listInvalidProperties" shared between parent and childs, but this would be a major structural change so this easy fix seems like a nice compromise.
|
@Herrick19 Why did you decide to close this PR? |
|
Hi, I Changed my mind and thought a separate function would be better. So if you check this pr: #6770 It does the same thing but in a better way IMO Best Regards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we deserialize a json structure, only the first level of validation is done and accessible with "listInvalidProperties"
To validate all sub objects, everyone would need to loop again on the objects and follow all properties, check if they are objects and call listInvalidProperties on each of them.
A better approach would be to have the "listInvalidProperties" shared between parent and childs, but this would be a major structural change so this easy fix seems like a nice compromise.