[17.0][FIX] spreadsheet_oca: Make use of _zip_xslx_files that spreadsheet module offers #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odule offers Reduce the logic of the controller by using the function that spreadsheet module offers and avoid error when rendering images on the xlsx file.
victoralmau
approved these changes
Sep 17, 2025
legalsylvain
requested changes
Sep 17, 2025
pedrobaeza
force-pushed
the
17.0-FIX-spreadsheet_oca
branch
from
cc76b53 to
d3a1ba3
Compare
pedrobaeza
approved these changes
Sep 17, 2025
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 90ea614. Thanks a lot for contributing to OCA. ❤️ |
|
The other patch is continued in #71 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the logic of the controller by using the function that spreadsheet module offers and avoid error when rendering images on the xlsx file.
cc @Tecnativa TT58039
ping @pedrobaeza @victoralmau