[18.0][MIG] spreadsheet_oca: Migration to 18.0 #72
Conversation
With this change we are adding an extra layer of security. Without it, any user was able to sniff how all happened using something like:
const any_spreadsheet_id = 1234;
const channel = "spreadsheet_oca;spreadsheet.spreadsheet;" + any_spreadsheet_id;
bus_service.addChannel(channel);
bus_service.addEventListener("spreadsheet_oca", (message) => /* every revision arrives here */
With the change, we verify the access to the model with a similar logic to `web_editor` fields
Hi @CarlosRoca13 Note that nothing should have been changed in the list data source insert, I left that working as it was before. |
|
Hmmm, okay... But if I want, for example, that the pivot has 10 rows instead of 2 that are set on the pivot? I don't see the way of doing this and I think it is a lost feature |
I agree it is a compromise, however couldn't find an alternative and wanted to keep it simple. |
chrisandrewmann
force-pushed
the
18.0-mig-spreadsheet_oca
branch
from
5bb34a9 to
5a54fb3
Compare
|
I made one last small update, added a feature which I feel is lacking and needed. Button on the list data side-panel. [IMP] Add feature to re-import lists from data sources in side-panel with selectable number of rows. 
|
|
Fixed the collaborative here: chrisandrewmann#1 |
Awesome! Thanks @etobella Merged and should be testable in here now. |
|
Please do a rebase a get rid-off the merge commit, and it would be nice if you squash administrative commits into the main one. |
chrisandrewmann
force-pushed
the
18.0-mig-spreadsheet_oca
branch
from
97defce to
69ae03c
Compare
Done! |
|
@CarlosRoca13 I tested locally and everything seemed to work. I see that you asked for some changed. They are still missing? |
Hi @etobella The creation of dynamic pivots with different number of rows, but I can add it in other PR. So I will not block this more time |
|
This PR has the |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 14157a6. Thanks a lot for contributing to OCA. ❤️ |
|
Agh, I was reducing commit history and you let me no time... |
|
@CarlosRoca13 the dynamic thing is not needed anymore:
|
I know that the pivots are dynamic by default, but in previous versions, I could add a dynamic pivot with more rows/columns than the shown on the pivot, now it is not possible. If you think that this is not necessary I will not invest time on recover it. |
|
Oh, okay, I see that the new row was added, sorry, I did not see it on my first watch |
|
/ocabot migration spreadsheet_oca |
17 participants
Continues and supercedes odoowired's PR #65
I'll summarise below.
Forward ported PRs from V17
Fixes done over original PR