[18.0][MIG] spreadsheet_oca: Migration to 18.0 #65

odoowired · 2025-07-30T08:56:02Z

No description provided.

tarteo

This is one heck of a module, thanks for your contribution!
I get an error when I go to a pivot view:

I'm also missing the "add to spreadsheet" buttons on list views:

TheToto42 · 2025-08-20T08:19:59Z

spreadsheet_oca/static/src/spreadsheet/bundle/spreadsheet_action.esm.js

+        spreadsheet_model.dispatch("ADD_PIVOT", {
+            pivotId: dataSourceId,
+            definition: pivot_info,
+        });
+        const dataSource = spreadsheet_model.getters.getPivotDataSource(dataSourceId);
+        await dataSource.load();


Hi @odoowired,

When installing your changes, I get an error over here:

UncaughtPromiseError > OwlError Uncaught Promise > An error occured in the owl lifecycle (see this Error's "cause" property) Occured on localhost:8069 on 2025-08-20 08:13:15 GMT OwlError: An error occured in the owl lifecycle (see this Error's "cause" property) OwlError@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:728:1 handleError@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:972:101 handleError@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:1619:29 initiateRender@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:1064:19 async*createComponent/<@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:1617:80 template@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js line 1574 > Function:12:21 _render@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:996:96 render@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:995:6 initiateRender@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:1065:47 async*createComponent/<@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:1617:80 template@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js line 1574 > Function:9:27 _render@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:996:96 render@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:995:6 initiateRender@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:1065:47 async*createComponent/<@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:1617:80 template@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js line 1574 > Function:14:43 _render@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:996:96 render@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:995:6 render@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:1073:56 async*render@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:1120:33 setup/this.onActionManagerUpdate@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:9933:101 trigger@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:764:63 _updateUI@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:10046:133 _executeClientAction@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:10062:181 async*doAction@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:10077:192 async*_executeClientAction@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:10062:275 async*doAction@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:10077:192 async*doActionButton@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:10088:255 async*execute@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:9690:314 async*executeButtonCallback@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:9683:40 onClickViewButton@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:9693:487 Caused by: TypeError: can't access property "measures", definition is undefined checkDuplicatedMeasureIds@http://localhost:8069/web/assets/a83aebc/spreadsheet.o_spreadsheet.min.js:8275:63 allowDispatch@http://localhost:8069/web/assets/a83aebc/spreadsheet.o_spreadsheet.min.js:8236:347 checkDispatchAllowedCoreCommand/results<@http://localhost:8069/web/assets/a83aebc/spreadsheet.o_spreadsheet.min.js:11749:96 checkDispatchAllowedCoreCommand@http://localhost:8069/web/assets/a83aebc/spreadsheet.o_spreadsheet.min.js:11749:73 checkDispatchAllowed@http://localhost:8069/web/assets/a83aebc/spreadsheet.o_spreadsheet.min.js:11747:73 dispatch@http://localhost:8069/web/assets/a83aebc/spreadsheet.o_spreadsheet.min.js:11755:41 importDataPivot@http://localhost:8069/web/assets/a83aebc/spreadsheet.o_spreadsheet.min.js:12954:661 importData@http://localhost:8069/web/assets/a83aebc/spreadsheet.o_spreadsheet.min.js:12958:84 setup/<@http://localhost:8069/web/assets/a83aebc/spreadsheet.o_spreadsheet.min.js:12922:1160 async*initiateRender/<@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:1063:80 initiateRender@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:1063:69 createComponent/<@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:1617:80 template@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js line 1574 > Function:12:21 _render@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:996:96 render@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:995:6 initiateRender@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:1065:47 async*createComponent/<@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:1617:80 template@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js line 1574 > Function:9:27 _render@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:996:96 render@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:995:6 initiateRender@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:1065:47 async*createComponent/<@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:1617:80 template@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js line 1574 > Function:14:43 _render@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:996:96 render@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:995:6 render@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:1073:56 async*render@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:1120:33 setup/this.onActionManagerUpdate@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:9933:101 trigger@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:764:63 _updateUI@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:10046:133 _executeClientAction@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:10062:181 async*doAction@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:10077:192 async*_executeClientAction@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:10062:275 async*doAction@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:10077:192 async*doActionButton@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:10088:255 async*execute@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:9690:314 async*executeButtonCallback@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:9683:40 onClickViewButton@http://localhost:8069/web/assets/2e8099d/web.assets_web.min.js:9693:487

By looking deeper into the code, I think "ADD_PIVOT" need the complete pivot object, which is why this error is triggered.

And I'm not sure the line after is still valid, i.e. I don't find any getPivotDataSource method anymore in Odoo 18

To reproduce the error, I just tried to insert a pivot view with some measures in a dashboard and the error pops up.

PS : I locally rollbacked some of your changes to match previous formatting to better see the real changes. I can share that to you if you want to merge it that way. I don't know what is the standard over that

TheToto42 · 2025-08-20T08:22:40Z

spreadsheet_oca/static/src/spreadsheet/pivot_controller.esm.js

+        var message = _l("Add to spreadsheet");
+        if (this.containsDuplicatedGroupBys()) {
+            message = _l("Duplicated groupbys in pivot are not supprted");
+        } else if (this.isComparingInfo()) {
+            message = _l("Comparisons in pivot are not supprted");


To fix @tarteo error, you can do this

Suggested change

var message = _l("Add to spreadsheet");

if (this.containsDuplicatedGroupBys()) {

message = _l("Duplicated groupbys in pivot are not supprted");

} else if (this.isComparingInfo()) {

message = _l("Comparisons in pivot are not supprted");

var message = _t("Add to spreadsheet");

if (this.containsDuplicatedGroupBys()) {

message = _t("Duplicated groupbys in pivot are not supprted");

} else if (this.isComparingInfo()) {

message = _t("Comparisons in pivot are not supprted");

After updating the import

import {_t} from "@web/core/l10n/translation";

@TheToto42 Thanks, I will add it now :)

With this change we are adding an extra layer of security. Without it, any user was able to sniff how all happened using something like: const any_spreadsheet_id = 1234; const channel = "spreadsheet_oca;spreadsheet.spreadsheet;" + any_spreadsheet_id; bus_service.addChannel(channel); bus_service.addEventListener("spreadsheet_oca", (message) => /* every revision arrives here */ With the change, we verify the access to the model with a similar logic to `web_editor` fields

…init logic to set default locale of new sheets

Currently translated at 100.0% (102 of 102 strings) Translation: spreadsheet-17.0/spreadsheet-17.0-spreadsheet_oca Translate-URL: https://translation.odoo-community.org/projects/spreadsheet-17-0/spreadsheet-17-0-spreadsheet_oca/it/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: spreadsheet-17.0/spreadsheet-17.0-spreadsheet_oca Translate-URL: https://translation.odoo-community.org/projects/spreadsheet-17-0/spreadsheet-17-0-spreadsheet_oca/

Currently translated at 100.0% (119 of 119 strings) Translation: spreadsheet-17.0/spreadsheet-17.0-spreadsheet_oca Translate-URL: https://translation.odoo-community.org/projects/spreadsheet-17-0/spreadsheet-17-0-spreadsheet_oca/it/

chrisandrewmann · 2025-09-16T08:58:09Z

Hi @odoowired, thanks for your contribution to this.
I worked on the V17 migration which was a challenge and this one seems even greater so imagine it will take a few people to achieve.

After testing your PR I also observed similar issues and have a partially working prototype that fixes some of them.
However I struggled to fully resolve all.
As there are so many changes, would you like me to send you my code so you can look through it and incorporate into your PR?
I can give you the Git diff here:
diff.patch

Fixed

Adding lists datasource to spreadsheets
Partial: Adding pivots datasource to spreadsheets - There is a problem with the date dimension which I can't quite solve
Inserting pivot and list from data sources panel
Editing pivot and list from data sources panel

Issues remaining

Charts from datasets can be inserted but cannot be edited - Crash when opening properties
Fixed: Pivots have issue when using date dimensions based on month for some reason, year / day all work ok
Undo / Redo logic not working: Since V17 there seems a disconnect between the revisions history and the GUI causing this to fail. Even keyboard shortcuts CTRL + Z don't work
Global filters dont work, saving has no effect

odoowired · 2025-09-16T09:12:37Z

@chrisandrewmann Thanks, I will include them. are you for some luck in the OCA days today or tomorrow?

chrisandrewmann · 2025-09-19T20:34:45Z

@chrisandrewmann Thanks, I will include them. are you for some luck in the OCA days today or tomorrow?

@odoowired I've fixed the Pivot date group-by issue.
Let me know once you've added my other changes, or I can give you a brand-new git diff instead.

gjlong68 · 2025-09-20T15:15:39Z

chrisandrewmann · 2025-09-22T20:29:07Z

@odoowired @tarteo Don't worry about doing anything with this. I've been busy over the last few days and have a fully working prototype with all previous issues solved, and a few new improvements added.
Hope to do a PR that supercedes this one soon.

Also have a version of spreadsheet_dashboard_oca which adds the ability to "Add to Dashboard" from the spreadsheet itself.

pedrobaeza · 2025-09-23T06:26:52Z

Please publish it, as we are waiting for a fully functional one.

odoowired · 2025-09-23T07:08:47Z

@chrisandrewmann Got some delays trying to fix on page refresh. But looks like everything is working. Let me know if you have other fixes that I could add here

chrisandrewmann · 2025-09-23T07:14:06Z

@chrisandrewmann Got some delays trying to fix on page refresh. But looks like everything is working. Let me know if you have other fixes that I could add here

There's too many changes to do it that way. I'll have to do a new PR and you can compare them.
I'll list out all the fixes in the description and refer to this one.
Also I've forward ported any V17 fixes that have been merged since.

chrisandrewmann · 2025-09-24T13:34:45Z

New PR submitted #72
@pedrobaeza @odoowired @tarteo

chrisandrewmann · 2025-10-09T10:37:56Z

@pedrobaeza @etobella This PR can be closed now since #72 has been merged please?

odoowired mentioned this pull request Jul 30, 2025

Migration to version 18.0 #50

Open

2 tasks

odoowired changed the title ~~[MIG] spreadsheet_oca: Migration to 18.0~~ [18.0][MIG] spreadsheet_oca: Migration to 18.0 Jul 30, 2025

odoowired force-pushed the 18.0-mig-spreadsheet_oca branch from 4ba6790 to c493841 Compare July 30, 2025 09:33

tarteo reviewed Aug 5, 2025

View reviewed changes

TheToto42 reviewed Aug 20, 2025

View reviewed changes

etobella and others added 24 commits September 16, 2025 09:11

[ADD] spreadsheet_oca

d6686c0

[UPD] Update spreadsheet_oca.pot

c667600

[UPD] README.rst

7e00d6e

[UPD] Update spreadsheet_oca.pot

038f824

spreadsheet_oca 16.0.1.0.1

f237c41

[IMP] spreadsheet_oca: Allow to import to existent spreadsheets

d9ffb62

[IMP] spreadsheet_oca: Allow to export graphs to spreadsheets

432b8d1

[IMP] spreadsheet_oca: add to current sheet

91f38f9

[UPD] Update spreadsheet_oca.pot

5598655

spreadsheet_oca 16.0.1.1.0

146f10d

[FIX] spreadsheet_oca: Ctrl+Z was not working properly

cd314e4

[IMP] spreadhseet_oca: Allow edition of sheet name

86e8088

[IMP] spreadsheet_oca: Allow to edit filters

f3f485d

[UPD] Update spreadsheet_oca.pot

b922dad

spreadsheet_oca 16.0.1.1.1

50a36f7

[UPD] Update spreadsheet_oca.pot

ef53259

[FIX] spreadsheet_oca: Filters where failing

56d087e

[IMP] spreadsheet_oca: Alloe to edit Pivot data

8701241

[IMP] spreadsheet_oca: Allow to import lists

faa349b

[IMP] spreadsheet_oca: Allow to edit lists

ce5f535

[IMP] spreadsheet_oca: Allow to reinsert a pivot table

bb2295c

[FIX] spreadsheet_oca: Fix filters

cb98c55

[UPD] Update spreadsheet_oca.pot

fb007ad

chrisandrewmann and others added 11 commits September 16, 2025 09:11

[FIX] Remove coding pragma and add contributor

f4c9b84

[IMP] spreadsheet_oca: pre-commit auto fixes

3322386

[IMP] Move spreadsheet data fields into spreadsheet_abstract and add …

ecf93c1

…init logic to set default locale of new sheets

[UPD] Update spreadsheet_oca.pot

342f9df

[BOT] post-merge updates

fb8baca

Added translation using Weblate (Chinese (Simplified) (zh_CN))

e8aac11

Translated using Weblate (Italian)

a416891

Currently translated at 100.0% (102 of 102 strings) Translation: spreadsheet-17.0/spreadsheet-17.0-spreadsheet_oca Translate-URL: https://translation.odoo-community.org/projects/spreadsheet-17-0/spreadsheet-17-0-spreadsheet_oca/it/

[UPD] Update spreadsheet_oca.pot

c05b295

Update translation files

a8804e0

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: spreadsheet-17.0/spreadsheet-17.0-spreadsheet_oca Translate-URL: https://translation.odoo-community.org/projects/spreadsheet-17-0/spreadsheet-17-0-spreadsheet_oca/

Translated using Weblate (Italian)

fbdcf58

Currently translated at 100.0% (119 of 119 strings) Translation: spreadsheet-17.0/spreadsheet-17.0-spreadsheet_oca Translate-URL: https://translation.odoo-community.org/projects/spreadsheet-17-0/spreadsheet-17-0-spreadsheet_oca/it/

[IMP] spreadsheet_oca: pre-commit auto fixes

1d943ca

odoowired force-pushed the 18.0-mig-spreadsheet_oca branch from c493841 to da03df0 Compare September 16, 2025 07:11

odoowired force-pushed the 18.0-mig-spreadsheet_oca branch from da03df0 to 6e24fe4 Compare September 23, 2025 06:58

[MIG] spreadsheet_oca: Migration to 18.0

b123d41

odoowired force-pushed the 18.0-mig-spreadsheet_oca branch from 6e24fe4 to b123d41 Compare September 23, 2025 07:07

odoowired requested review from TheToto42 and tarteo September 23, 2025 07:09

tarteo mentioned this pull request Sep 24, 2025

[18.0] Migration spreadsheet modules (spreadsheet_oca, spreadsheet_dashboard_oca, spreadsheet_oca_ux) onesteinbv/addons-curq#287

Closed

chrisandrewmann mentioned this pull request Sep 24, 2025

[18.0][MIG] spreadsheet_oca: Migration to 18.0 #72

Merged

pedrobaeza closed this Oct 9, 2025

Uh oh!

[18.0][MIG] spreadsheet_oca: Migration to 18.0 #65

[18.0][MIG] spreadsheet_oca: Migration to 18.0 #65

Uh oh!

Conversation

odoowired commented Jul 30, 2025

Uh oh!

tarteo left a comment

Choose a reason for hiding this comment

Uh oh!

TheToto42 Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

TheToto42 Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

odoowired Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

chrisandrewmann commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fixed

Issues remaining

Uh oh!

odoowired commented Sep 16, 2025

Uh oh!

chrisandrewmann commented Sep 19, 2025

Uh oh!

gjlong68 commented Sep 20, 2025

Uh oh!

chrisandrewmann commented Sep 22, 2025

Uh oh!

pedrobaeza commented Sep 23, 2025

Uh oh!

odoowired commented Sep 23, 2025

Uh oh!

chrisandrewmann commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chrisandrewmann commented Sep 24, 2025

Uh oh!

chrisandrewmann commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

chrisandrewmann commented Sep 16, 2025 •

edited

Loading

chrisandrewmann commented Sep 23, 2025 •

edited

Loading

chrisandrewmann commented Oct 9, 2025 •

edited

Loading