-
Notifications
You must be signed in to change notification settings - Fork 841
feature: allow rebuilding conda/pypi environments #2442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
saikonen
wants to merge
5
commits into
master
Choose a base branch
from
feature/conda-force-rebuild
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
780bd18
wip: initial working command for environment init
saikonen 8adcea2
add force_rebuild flag to conda environment
saikonen d019e14
cleanup
saikonen b1ade4e
add deleting of existing environments
saikonen 1022cdb
rename cmd to resolve and add --force flag
saikonen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
from metaflow._vendor import click | ||
from metaflow.exception import MetaflowException | ||
|
||
|
||
@click.group() | ||
def cli(): | ||
pass | ||
|
||
|
||
@cli.group(help="Commands related to managing the conda/pypi environments") | ||
@click.pass_context | ||
def environment(ctx): | ||
# the logger is configured in cli.py | ||
global echo | ||
echo = ctx.obj.echo | ||
|
||
|
||
@environment.command(help="Resolve the environment(s)") | ||
@click.option( | ||
"--step", | ||
"steps", | ||
multiple=True, | ||
default=[], | ||
help="Steps to resolve the environment for", | ||
) | ||
@click.option( | ||
"--force/--no-force", | ||
default=False, | ||
is_flag=True, | ||
help="Force re-resolving the environment(s)", | ||
) | ||
@click.pass_obj | ||
def resolve(obj, steps, force=False): | ||
# possibly limiting steps to resolve. make sure its a list and not a tuple | ||
step_names = list(steps) | ||
|
||
steps = [step for step in obj.flow if (step.name in step_names) or not step_names] | ||
|
||
# Delete existing environments if we are rebuilding. | ||
if force: | ||
for step in steps: | ||
obj.environment.delete_environment(step) | ||
|
||
if not hasattr(obj.environment, "disable_cache"): | ||
raise MetaflowException("The environment does not support disabling the cache.") | ||
|
||
# Disable the cache before initializing if we are rebuilding. | ||
if force: | ||
obj.environment.disable_cache() | ||
obj.environment.init_environment(echo, only_steps=step_names) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: the other plugin uses those as argument
resolve start end mid
isntead of--step start --start end
.