Skip to content

feature: allow rebuilding conda/pypi environments #2442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

saikonen
Copy link
Collaborator

@saikonen saikonen commented Jun 4, 2025

this PR adds a command for forcing a rebuild of the conda/pypi environment(s) of a flow.

# rebuild all environments
HelloConda.py --environment conda environment rebuild

# specify any number of steps to rebuild only their environments
HelloConda.py --environment conda environment rebuild --step start --step end

@saikonen saikonen requested a review from savingoyal June 4, 2025 21:28
@romain-intel
Copy link
Contributor

General comment: could we align on the names. The extension already does this: https://github.com/Netflix/metaflow-nflx-extensions/blob/main/metaflow_extensions/netflix_ext/plugins/environment_cli.py and for the limited functionality supported here, we could do the same names (ie: resolve --force) which may make things a bit more consistent.

Copy link
Contributor

@romain-intel romain-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No comment on the functionality or how you want to make it work but apart from a minor nit, the command looks fine.

echo = ctx.obj.echo


@environment.command(help="Resolve the environment(s)")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: the other plugin uses those as argument resolve start end mid isntead of --step start --start end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants