-
Notifications
You must be signed in to change notification settings - Fork 11.6k
[graphql-alt] Support identifier for ExectionError #22866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tpham-mysten
merged 2 commits into
main
from
graphql-alt-transaction-effects-execution-errors-identifer
Jul 29, 2025
Merged
[graphql-alt] Support identifier for ExectionError #22866
tpham-mysten
merged 2 commits into
main
from
graphql-alt-transaction-effects-execution-errors-identifer
Jul 29, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
7 tasks
emmazzz
reviewed
Jul 24, 2025
crates/sui-indexer-alt-e2e-tests/tests/graphql/transaction_effects/execution_error.move
Outdated
Show resolved
Hide resolved
adac546
to
8b47644
Compare
5aa3088
to
ac8e3c1
Compare
8b47644
to
afb4243
Compare
ac8e3c1
to
0443904
Compare
0443904
to
28622c2
Compare
28622c2
to
f6698bf
Compare
emmazzz
approved these changes
Jul 27, 2025
amnn
approved these changes
Jul 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
crates/sui-indexer-alt-graphql/src/api/types/execution_error.rs
Outdated
Show resolved
Hide resolved
afb4243
to
7cc0577
Compare
Base automatically changed from
graphql-alt-transaction-effects-execution-errors-instruction-offset
to
main
July 29, 2025 02:34
f6698bf
to
52a6232
Compare
tpham-mysten
added a commit
that referenced
this pull request
Jul 29, 2025
## Description Implement `constant` field support for `ExectionError` type. ## Test plan How did you test the new or updated feature? ``` cargo nextest run -p sui-indexer-alt-graphql cargo nextest run -p sui-indexer-alt-reader cargo nextest run -p sui-indexer-alt-e2e-tests -- graphql ``` --- ## Stack - #22791 - #22864 - #22865 - #22866 - #22867 ⬅️ ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] gRPC: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement
identifier
field support forExectionError
type.Test plan
How did you test the new or updated feature?
Stack
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.