Skip to content

[graphql-alt] Support identifier for ExectionError #22866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tpham-mysten
Copy link
Contributor

@tpham-mysten tpham-mysten commented Jul 24, 2025

Description

Implement identifier field support for ExectionError type.

Test plan

How did you test the new or updated feature?

cargo nextest run -p sui-indexer-alt-graphql
cargo nextest run -p sui-indexer-alt-reader
cargo nextest run -p sui-indexer-alt-e2e-tests -- graphql

Stack

Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

@tpham-mysten tpham-mysten requested a review from a team as a code owner July 24, 2025 03:24
Copy link

vercel bot commented Jul 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ❌ Failed (Inspect) Jul 29, 2025 2:48am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2025 2:48am
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2025 2:48am

@tpham-mysten tpham-mysten requested review from amnn, emmazzz and wlmyng July 24, 2025 03:24
@tpham-mysten tpham-mysten changed the base branch from main to graphql-alt-transaction-effects-execution-errors-instruction-offset July 24, 2025 17:17
@tpham-mysten tpham-mysten force-pushed the graphql-alt-transaction-effects-execution-errors-instruction-offset branch from adac546 to 8b47644 Compare July 25, 2025 03:30
@tpham-mysten tpham-mysten force-pushed the graphql-alt-transaction-effects-execution-errors-identifer branch from 5aa3088 to ac8e3c1 Compare July 25, 2025 03:54
@tpham-mysten tpham-mysten temporarily deployed to sui-typescript-aws-kms-test-env July 25, 2025 03:54 — with GitHub Actions Inactive
@tpham-mysten tpham-mysten force-pushed the graphql-alt-transaction-effects-execution-errors-instruction-offset branch from 8b47644 to afb4243 Compare July 25, 2025 04:00
@tpham-mysten tpham-mysten force-pushed the graphql-alt-transaction-effects-execution-errors-identifer branch from ac8e3c1 to 0443904 Compare July 25, 2025 04:14
@tpham-mysten tpham-mysten force-pushed the graphql-alt-transaction-effects-execution-errors-identifer branch from 0443904 to 28622c2 Compare July 25, 2025 04:24
@tpham-mysten tpham-mysten temporarily deployed to sui-typescript-aws-kms-test-env July 25, 2025 04:24 — with GitHub Actions Inactive
@tpham-mysten tpham-mysten requested a review from emmazzz July 25, 2025 04:24
@tpham-mysten tpham-mysten force-pushed the graphql-alt-transaction-effects-execution-errors-identifer branch from 28622c2 to f6698bf Compare July 25, 2025 04:34
@tpham-mysten tpham-mysten temporarily deployed to sui-typescript-aws-kms-test-env July 25, 2025 04:34 — with GitHub Actions Inactive
Copy link
Contributor

@amnn amnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@tpham-mysten tpham-mysten force-pushed the graphql-alt-transaction-effects-execution-errors-instruction-offset branch from afb4243 to 7cc0577 Compare July 29, 2025 01:57
Base automatically changed from graphql-alt-transaction-effects-execution-errors-instruction-offset to main July 29, 2025 02:34
@tpham-mysten tpham-mysten force-pushed the graphql-alt-transaction-effects-execution-errors-identifer branch from f6698bf to 52a6232 Compare July 29, 2025 02:42
@tpham-mysten tpham-mysten temporarily deployed to sui-typescript-aws-kms-test-env July 29, 2025 02:42 — with GitHub Actions Inactive
@tpham-mysten tpham-mysten temporarily deployed to sui-typescript-aws-kms-test-env July 29, 2025 02:47 — with GitHub Actions Inactive
@tpham-mysten tpham-mysten merged commit 8765a71 into main Jul 29, 2025
53 of 54 checks passed
@tpham-mysten tpham-mysten deleted the graphql-alt-transaction-effects-execution-errors-identifer branch July 29, 2025 03:31
tpham-mysten added a commit that referenced this pull request Jul 29, 2025
## Description 

Implement `constant` field support for `ExectionError` type.

## Test plan 

How did you test the new or updated feature?

```
cargo nextest run -p sui-indexer-alt-graphql
cargo nextest run -p sui-indexer-alt-reader
cargo nextest run -p sui-indexer-alt-e2e-tests -- graphql
```

---

## Stack 
- #22791
- #22864 
- #22865
- #22866 
- #22867 ⬅️


## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] gRPC:
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [ ] CLI: 
- [ ] Rust SDK:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants