Skip to content

[graphql-alt] Support constant for ExectionError #22867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tpham-mysten
Copy link
Contributor

@tpham-mysten tpham-mysten commented Jul 24, 2025

Description

Implement constant field support for ExectionError type.

Test plan

How did you test the new or updated feature?

cargo nextest run -p sui-indexer-alt-graphql
cargo nextest run -p sui-indexer-alt-reader
cargo nextest run -p sui-indexer-alt-e2e-tests -- graphql

Stack

Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

@tpham-mysten tpham-mysten requested a review from a team as a code owner July 24, 2025 03:36
Copy link

vercel bot commented Jul 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ❌ Failed (Inspect) Jul 29, 2025 4:26am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2025 4:26am
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2025 4:26am

@emmazzz
Copy link
Contributor

emmazzz commented Jul 24, 2025

@tpham-mysten Could you change the base branch from main to the previous feature branch graphql-alt-transaction-effects-execution-errors-identifer in your stack? Thanks!

@tpham-mysten tpham-mysten force-pushed the graphql-alt-transaction-effects-execution-errors-constant branch from 8735cfa to d18e9ee Compare July 25, 2025 04:30
@tpham-mysten tpham-mysten changed the base branch from main to graphql-alt-transaction-effects-execution-errors-identifer July 25, 2025 04:31
@tpham-mysten tpham-mysten force-pushed the graphql-alt-transaction-effects-execution-errors-identifer branch from 28622c2 to f6698bf Compare July 25, 2025 04:34
@tpham-mysten tpham-mysten force-pushed the graphql-alt-transaction-effects-execution-errors-constant branch from d18e9ee to 8d031ba Compare July 25, 2025 04:37
@tpham-mysten tpham-mysten temporarily deployed to sui-typescript-aws-kms-test-env July 25, 2025 04:37 — with GitHub Actions Inactive
@tpham-mysten
Copy link
Contributor Author

Thanks for catching! I have rebased.

}
},
"cleverString": {
"executionError": {
"abortCode": "13906834380502335497",
"sourceLineNumber": 48,
"instructionOffset": 1,
"identifier": "ECleverString"
"identifier": "ECleverString",
"constant": "This is a clever error message"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such an improvement over our old error system - I'm tearing up 🥹

Copy link
Contributor

@amnn amnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Small tweak for raw constants.

@tpham-mysten tpham-mysten force-pushed the graphql-alt-transaction-effects-execution-errors-identifer branch from f6698bf to 52a6232 Compare July 29, 2025 02:42
Base automatically changed from graphql-alt-transaction-effects-execution-errors-identifer to main July 29, 2025 03:31
@tpham-mysten tpham-mysten force-pushed the graphql-alt-transaction-effects-execution-errors-constant branch from 8d031ba to efdba2b Compare July 29, 2025 04:10
@tpham-mysten tpham-mysten temporarily deployed to sui-typescript-aws-kms-test-env July 29, 2025 04:10 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants