-
Notifications
You must be signed in to change notification settings - Fork 11.6k
[graphql-alt] Support constant for ExectionError #22867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[graphql-alt] Support constant for ExectionError #22867
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
@tpham-mysten Could you change the base branch from |
8735cfa
to
d18e9ee
Compare
28622c2
to
f6698bf
Compare
d18e9ee
to
8d031ba
Compare
Thanks for catching! I have rebased. |
} | ||
}, | ||
"cleverString": { | ||
"executionError": { | ||
"abortCode": "13906834380502335497", | ||
"sourceLineNumber": 48, | ||
"instructionOffset": 1, | ||
"identifier": "ECleverString" | ||
"identifier": "ECleverString", | ||
"constant": "This is a clever error message" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Such an improvement over our old error system - I'm tearing up 🥹
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Small tweak for raw constants.
crates/sui-indexer-alt-graphql/src/api/types/execution_error.rs
Outdated
Show resolved
Hide resolved
f6698bf
to
52a6232
Compare
8d031ba
to
efdba2b
Compare
Description
Implement
constant
field support forExectionError
type.Test plan
How did you test the new or updated feature?
Stack
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.