Skip to content

[graphql-alt] Support epoch for TransactionEffects #22825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025

Conversation

tpham-mysten
Copy link
Contributor

@tpham-mysten tpham-mysten commented Jul 22, 2025

Description

Implement epoch field support for TransactionEffects type.

Reference: Based on legacy implementation in sui/crates/sui-graphql-rpc/src/types /transaction_block_effects.rs

Test plan

How did you test the new or updated feature?

cargo nextest run -p sui-indexer-alt-graphql
cargo nextest run -p sui-indexer-alt-reader
cargo nextest run -p sui-indexer-alt-e2e-tests -- graphql

Stack

Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

@tpham-mysten tpham-mysten requested a review from a team as a code owner July 22, 2025 13:45
Copy link

vercel bot commented Jul 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ❌ Failed (Inspect) Jul 29, 2025 0:10am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2025 0:10am
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2025 0:10am

@tpham-mysten tpham-mysten temporarily deployed to sui-typescript-aws-kms-test-env July 22, 2025 13:45 — with GitHub Actions Inactive
@tpham-mysten tpham-mysten requested review from amnn, emmazzz and wlmyng July 22, 2025 13:45
@tpham-mysten tpham-mysten force-pushed the graphql-alt-transaction-effects-epoch branch from 7735ad4 to 5b0004e Compare July 22, 2025 13:55
@tpham-mysten tpham-mysten temporarily deployed to sui-typescript-aws-kms-test-env July 22, 2025 13:55 — with GitHub Actions Inactive
@tpham-mysten tpham-mysten changed the base branch from main to graphql-alt-transaction-effects-timestamp July 22, 2025 13:55
@tpham-mysten tpham-mysten force-pushed the graphql-alt-transaction-effects-timestamp branch 3 times, most recently from af74f9f to c26b3b5 Compare July 28, 2025 21:12
Base automatically changed from graphql-alt-transaction-effects-timestamp to main July 28, 2025 23:19
@tpham-mysten tpham-mysten force-pushed the graphql-alt-transaction-effects-epoch branch from 6d8ebba to 278118c Compare July 28, 2025 23:32
@tpham-mysten tpham-mysten had a problem deploying to sui-typescript-aws-kms-test-env July 28, 2025 23:32 — with GitHub Actions Failure
@tpham-mysten tpham-mysten force-pushed the graphql-alt-transaction-effects-epoch branch from 278118c to 6e235d7 Compare July 29, 2025 00:09
@tpham-mysten tpham-mysten temporarily deployed to sui-typescript-aws-kms-test-env July 29, 2025 00:09 — with GitHub Actions Inactive
@tpham-mysten tpham-mysten merged commit 75eb9b8 into main Jul 29, 2025
53 of 54 checks passed
@tpham-mysten tpham-mysten deleted the graphql-alt-transaction-effects-epoch branch July 29, 2025 00:48
tpham-mysten added a commit that referenced this pull request Jul 29, 2025
## Description 

Implement `events` field for `TransactionEffects` type.

Within this PR, I also create a scheme for new `Event` type with
following fields:
* eventBcs
* sequenceNumber
* sender
* transaction
* timestamp

Currently, we cannot support 2 fields `sendingModule` and `contents` as
`MoveModule`
([DVX-1205](https://linear.app/mysten-labs/issue/DVX-1205/movemodule))
and `MoveValue`
([DVX-1206](https://linear.app/mysten-labs/issue/DVX-1206/movevalue))
have not yet been supported. I already added a TODO to support that
field later after getting unblocked.

## Test plan 

How did you test the new or updated feature?

```
cargo nextest run -p sui-indexer-alt-graphql
cargo nextest run -p sui-indexer-alt-reader
cargo nextest run -p sui-indexer-alt-e2e-tests -- graphql
```

---

## Stack
- #22789 
- #22790 
- #22822 
- #22823 
- #22825 
- #22835 ⬅️

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] gRPC:
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [ ] CLI: 
- [ ] Rust SDK:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants