-
Notifications
You must be signed in to change notification settings - Fork 11.6k
[graphql-alt] Support epoch for TransactionEffects #22825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
7735ad4
to
5b0004e
Compare
7 tasks
wlmyng
approved these changes
Jul 22, 2025
7 tasks
5b0004e
to
6d8ebba
Compare
37b4938
to
3c5af19
Compare
emmazzz
approved these changes
Jul 23, 2025
7 tasks
af74f9f
to
c26b3b5
Compare
Base automatically changed from
graphql-alt-transaction-effects-timestamp
to
main
July 28, 2025 23:19
6d8ebba
to
278118c
Compare
278118c
to
6e235d7
Compare
tpham-mysten
added a commit
that referenced
this pull request
Jul 29, 2025
## Description Implement `events` field for `TransactionEffects` type. Within this PR, I also create a scheme for new `Event` type with following fields: * eventBcs * sequenceNumber * sender * transaction * timestamp Currently, we cannot support 2 fields `sendingModule` and `contents` as `MoveModule` ([DVX-1205](https://linear.app/mysten-labs/issue/DVX-1205/movemodule)) and `MoveValue` ([DVX-1206](https://linear.app/mysten-labs/issue/DVX-1206/movevalue)) have not yet been supported. I already added a TODO to support that field later after getting unblocked. ## Test plan How did you test the new or updated feature? ``` cargo nextest run -p sui-indexer-alt-graphql cargo nextest run -p sui-indexer-alt-reader cargo nextest run -p sui-indexer-alt-e2e-tests -- graphql ``` --- ## Stack - #22789 - #22790 - #22822 - #22823 - #22825 - #22835 ⬅️ ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] gRPC: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement
epoch
field support forTransactionEffects
type.Reference: Based on legacy implementation in sui/crates/sui-graphql-rpc/src/types /transaction_block_effects.rs
Test plan
How did you test the new or updated feature?
Stack
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.