Skip to content

[graphql-alt] Support balance_changes for TransactionEffects #22843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2025

Conversation

tpham-mysten
Copy link
Contributor

@tpham-mysten tpham-mysten commented Jul 23, 2025

Description

Implement balance_changes field support for TransactionEffects type.

Reference: Based on legacy implementation in sui/crates/sui-graphql-rpc/src/types /transaction_block_effects.rs

Test plan

How did you test the new or updated feature?

cargo nextest run -p sui-indexer-alt-graphql
cargo nextest run -p sui-indexer-alt-reader
cargo nextest run -p sui-indexer-alt-e2e-tests -- graphql

Stack

Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

@tpham-mysten tpham-mysten requested a review from a team as a code owner July 23, 2025 02:52
Copy link

vercel bot commented Jul 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2025 1:59pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2025 1:59pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2025 1:59pm

@tpham-mysten tpham-mysten changed the base branch from main to graphql-alt-transaction-effects-events July 23, 2025 03:11
@tpham-mysten tpham-mysten force-pushed the graphql-alt-transaction-effects-events branch from 529f5bb to 906e347 Compare July 23, 2025 03:38
@amnn
Copy link
Contributor

amnn commented Jul 28, 2025

Heads up that this needs to be rebased on top of your changes for events. I will review the top commit for now.

Copy link
Contributor

@amnn amnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good modulo a rebase and the nits, thanks @tpham-mysten !

@tpham-mysten tpham-mysten force-pushed the graphql-alt-transaction-effects-events branch from 906e347 to 64e9f09 Compare July 29, 2025 00:57
Base automatically changed from graphql-alt-transaction-effects-events to main July 29, 2025 01:38
@tpham-mysten tpham-mysten force-pushed the graphql-alt-transaction-effects-balance-changes branch from 524963b to 4c4d7ed Compare July 29, 2025 13:52
@tpham-mysten tpham-mysten temporarily deployed to sui-typescript-aws-kms-test-env July 29, 2025 13:52 — with GitHub Actions Inactive
Copy link
Contributor Author

@tpham-mysten tpham-mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the detailed review 🙏

@tpham-mysten tpham-mysten merged commit a7cb83c into main Jul 29, 2025
69 of 70 checks passed
@tpham-mysten tpham-mysten deleted the graphql-alt-transaction-effects-balance-changes branch July 29, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants