fix: enable and update attestation document parsing logic #22120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
joyqvq
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
benr-ml
approved these changes
May 13, 2025
joyqvq
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
joyqvq
changed the title
joyqvq
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
benr-ml
reviewed
May 14, 2025
| @@ -594,8 +594,30 @@ impl AttestationDocument { | |||
| pcr_vec.push(value.to_vec()); | |||
| } | |||
| } | |||
|
|
|||
| // valid key is 0..31, can parse with u8. | |||
| let key_u8 = u8::try_from(key).map_err(|_| { | |||
There was a problem hiding this comment.
we already defined it above
There was a problem hiding this comment.
yeah but i changed it from u64 to u8 since the valid values can be 0..31 only!
There was a problem hiding this comment.
so you probably want to guard that try_from with is_upgraded_parsing as well, no?
There was a problem hiding this comment.
yes😅all error paths on the new parsing logic here should be guarded.
| continue; | ||
| } | ||
|
|
||
| if pcr_map.contains_key(&key_u8) { |
There was a problem hiding this comment.
we need to check here that !is_upgraded_parsing, no?
joyqvq
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
joyqvq
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
benr-ml
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes or additions included in this PR.
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.