fix: enable and update attestation document parsing logic

Author: joyqvq

crates/sui-framework/packages/sui-framework/tests/crypto/nitro_attestation_test.move

@@ -1327,6 +1327,7 @@
                 "enable_group_ops_native_functions": false,
                 "enable_jwk_consensus_updates": false,
                 "enable_nitro_attestation": false,
+                "enable_nitro_attestation_upgraded_parsing": false,
                 "enable_party_transfer": false,
                 "enable_poseidon": false,
                 "enable_vdf": false,

crates/sui-open-rpc/spec/openrpc.json

@@ -237,6 +237,7 @@ const MAX_PROTOCOL_VERSION: u64 = 83;
 //             Increase threshold for bad nodes that won't be considered leaders in consensus in mainnet
 // Version 82: Relax bounding of size of values created in the adapter.
 // Version 83: Resolve `TypeInput` IDs to defining ID when converting to `TypeTag`s in the adapter.
+//             Enable nitro attestation upgraded parsing and mainnet.
 
 #[derive(Copy, Clone, Debug, Hash, Serialize, Deserialize, PartialEq, Eq, PartialOrd, Ord)]
 pub struct ProtocolVersion(u64);
@@ -502,6 +503,10 @@ struct FeatureFlags {
     #[serde(skip_serializing_if = "is_false")]
     enable_nitro_attestation: bool,
 
+    // Enable upgraded parsing of nitro attestation that interprets pcrs as a map.
+    #[serde(skip_serializing_if = "is_false")]
+    enable_nitro_attestation_upgraded_parsing: bool,
+
     // Reject functions with mutable Random.
     #[serde(skip_serializing_if = "is_false")]
     reject_mutable_random_on_entry_functions: bool,
@@ -1926,6 +1931,10 @@ impl ProtocolConfig {
         self.feature_flags.enable_nitro_attestation
     }
 
+    pub fn enable_nitro_attestation_upgraded_parsing(&self) -> bool {
+        self.feature_flags.enable_nitro_attestation_upgraded_parsing
+    }
+
     pub fn get_consensus_commit_rate_estimation_window_size(&self) -> u32 {
         self.consensus_commit_rate_estimation_window_size
             .unwrap_or(0)
@@ -3508,6 +3517,8 @@ impl ProtocolConfig {
                 83 => {
                     cfg.feature_flags.resolve_type_input_ids_to_defining_id = true;
                     cfg.transfer_party_transfer_internal_cost_base = Some(52);
+                    cfg.feature_flags.enable_nitro_attestation_upgraded_parsing = true;
+                    cfg.feature_flags.enable_nitro_attestation = true;
                 }
                 // Use this template when making changes:
                 //

crates/sui-protocol-config/src/lib.rs

@@ -1,6 +1,7 @@
 ---
 source: crates/sui-protocol-config/src/lib.rs
 expression: "ProtocolConfig::get_for_version(cur, *chain_id)"
+snapshot_kind: text
 ---
 version: 83
 feature_flags:
@@ -44,6 +45,8 @@ feature_flags:
   allow_receiving_object_id: true
   enable_coin_deny_list: true
   enable_group_ops_native_functions: true
+  enable_nitro_attestation: true
+  enable_nitro_attestation_upgraded_parsing: true
   reject_mutable_random_on_entry_functions: true
   per_object_congestion_control_mode: TotalGasBudgetWithCap
   consensus_choice: Mysticeti

crates/sui-protocol-config/src/snapshots/sui_protocol_config__test__Mainnet_version_83.snap

@@ -1,6 +1,7 @@
 ---
 source: crates/sui-protocol-config/src/lib.rs
 expression: "ProtocolConfig::get_for_version(cur, *chain_id)"
+snapshot_kind: text
 ---
 version: 83
 feature_flags:
@@ -46,6 +47,7 @@ feature_flags:
   enable_coin_deny_list: true
   enable_group_ops_native_functions: true
   enable_nitro_attestation: true
+  enable_nitro_attestation_upgraded_parsing: true
   reject_mutable_random_on_entry_functions: true
   per_object_congestion_control_mode:
     ExecutionTimeEstimate:

crates/sui-protocol-config/src/snapshots/sui_protocol_config__test__Testnet_version_83.snap

@@ -1,6 +1,7 @@
 ---
 source: crates/sui-protocol-config/src/lib.rs
 expression: "ProtocolConfig::get_for_version(cur, *chain_id)"
+snapshot_kind: text
 ---
 version: 83
 feature_flags:
@@ -48,6 +49,7 @@ feature_flags:
   enable_group_ops_native_functions: true
   enable_group_ops_native_function_msm: true
   enable_nitro_attestation: true
+  enable_nitro_attestation_upgraded_parsing: true
   reject_mutable_random_on_entry_functions: true
   per_object_congestion_control_mode:
     ExecutionTimeEstimate: