[3/n][object runtime type tags] Add type tags to object runtime update adapter to handle them #22092
+380
−157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tzakian
commented
May 9, 2025
| @@ -910,6 +929,13 @@ mod checked { | |||
| written_objects.insert(id, object); | |||
| } | |||
|
|
|||
| for package in new_packages { | |||
There was a problem hiding this comment.
This got moved down as we need to use new_package up above when loading the type. This shouldn't have any effect, but double check me 🙏🏻
tzakian
commented
May 9, 2025
| protocol_config: &ProtocolConfig, | ||
| ty: Result<Type, ExecutionError>, | ||
| ) -> Result<Type, ExecutionError> { | ||
| if ty.is_err() && !protocol_config.type_tags_in_object_runtime() { |
There was a problem hiding this comment.
This should never happen, but just to be paranoid, panic in case it does and we're before this feature is enabled
tzakian
commented
May 9, 2025
| // they were published in the current transaction). Note that this needs to load `MovePackage`s and | ||
| // not `MovePackageObject`s. | ||
| pub trait PackageStore { | ||
| fn get_package(&self, id: &ObjectID) -> SuiResult<Option<Rc<MovePackage>>>; |
There was a problem hiding this comment.
This will be used in future PRs as well. This will be quite useful for e.g., caching layers and a lot more ;)
tzakian
force-pushed
the
tzakian/type-tags-obj-runtime3
branch
from
6ea7e45 to
34db4dc
Compare
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tzakian
force-pushed
the
tzakian/type-tags-obj-runtime2
branch
from
0f6c369 to
6e2ed2f
Compare
tzakian
requested review from
amnn,
wlmyng,
stefan-mysten and
emmazzz
as code owners
tzakian
force-pushed
the
tzakian/type-tags-obj-runtime3
branch
from
34db4dc to
f229416
Compare
tzakian
force-pushed
the
tzakian/type-tags-obj-runtime3
branch
from
f229416 to
4da3d3b
Compare
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tnowacki
reviewed
May 13, 2025
external-crates/move/crates/move-vm-runtime/src/native_functions.rs
Outdated
Show resolved
Hide resolved
external-crates/move/crates/move-vm-runtime/src/native_functions.rs
Outdated
Show resolved
Hide resolved
sui-execution/latest/sui-adapter/src/programmable_transactions/context.rs
Show resolved
Hide resolved
tnowacki
approved these changes
May 14, 2025
tzakian
force-pushed
the
tzakian/type-tags-obj-runtime3
branch
from
4da3d3b to
f454c3a
Compare
…e adapter to handle them.
tzakian
force-pushed
the
tzakian/type-tags-obj-runtime3
branch
from
f454c3a to
2053106
Compare
tzakian
force-pushed
the
tzakian/type-tags-obj-runtime3
branch
from
2053106 to
9b50333
Compare
tzakian
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates the object runtime to only hold
TypeTags (orMoveObjecTypes where appropriate) instead of VM runtimeTypes.It's generally a pretty straightforward change, however there are a couple places worth calling out specifically and I've done so in-line.
Test plan
CI + adding new tests to make sure type tags coming from the object runtime are correctly resolved in newly-published packages.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.