[3/n][object runtime type tags] Add type tags to object runtime update adapter to handle them.

Author: Timothy Zakian

crates/sui-adapter-transactional-tests/tests/init/create_object.move

@@ -0,0 +1,17 @@
+// Copyright (c) Mysten Labs, Inc.
+// SPDX-License-Identifier: Apache-2.0
+
+//# init --addresses Test=0x0
+
+//# publish
+module Test::M1 {
+   public struct X has key {
+       id: UID,
+   }
+
+   fun init(ctx: &mut TxContext) { 
+       sui::transfer::transfer(X { id: object::new(ctx) }, ctx.sender());
+   }
+}
+
+//# view-object 1,1

crates/sui-adapter-transactional-tests/tests/init/create_object.snap

@@ -0,0 +1,22 @@
+---
+source: external-crates/move/crates/move-transactional-test-runner/src/framework.rs
+---
+processed 3 tasks
+
+task 1, lines 6-15:
+//# publish
+created: object(1,0), object(1,1)
+mutated: object(0,0)
+gas summary: computation_cost: 1000000, storage_cost: 6216800,  storage_rebate: 0, non_refundable_storage_fee: 0
+
+task 2, line 17:
+//# view-object 1,1
+Owner: Account Address ( _ )
+Version: 2
+Contents: Test::M1::X {
+    id: sui::object::UID {
+        id: sui::object::ID {
+            bytes: fake(1,1),
+        },
+    },
+}

crates/sui-adapter-transactional-tests/tests/init/emit_event.move

@@ -0,0 +1,17 @@
+// Copyright (c) Mysten Labs, Inc.
+// SPDX-License-Identifier: Apache-2.0
+
+//# init --addresses Test=0x0
+
+//# publish
+module Test::M1 {
+   public struct Event has copy, drop, store {
+       x: u64,
+   }
+
+   fun init(_ctx: &mut TxContext) { 
+       sui::event::emit(Event { x: 1 });
+   }
+}
+
+//# view-object 1,0

crates/sui-adapter-transactional-tests/tests/init/emit_event.snap

@@ -0,0 +1,15 @@
+---
+source: external-crates/move/crates/move-transactional-test-runner/src/framework.rs
+---
+processed 3 tasks
+
+task 1, lines 6-15:
+//# publish
+events: Event { package_id: Test, transaction_module: Identifier("M1"), sender: _, type_: StructTag { address: Test, module: Identifier("M1"), name: Identifier("Event"), type_params: [] }, contents: [1, 0, 0, 0, 0, 0, 0, 0] }
+created: object(1,0)
+mutated: object(0,0)
+gas summary: computation_cost: 1000000, storage_cost: 4689200,  storage_rebate: 0, non_refundable_storage_fee: 0
+
+task 2, line 17:
+//# view-object 1,0
+1,0::M1

crates/sui-open-rpc/spec/openrpc.json

@@ -1373,6 +1373,7 @@
                 "soft_bundle": false,
                 "throughput_aware_consensus_submission": false,
                 "txn_base_cost_as_multiplier": false,
+                "type_tags_in_object_runtime": false,
                 "uncompressed_g1_group_elements": false,
                 "upgraded_multisig_supported": false,
                 "validate_identifier_inputs": false,

crates/sui-protocol-config/src/lib.rs

@@ -684,6 +684,10 @@ struct FeatureFlags {
     // If true, resolves all type input ids to be defining ID based in the adapter
     #[serde(skip_serializing_if = "is_false")]
     resolve_type_input_ids_to_defining_id: bool,
+
+    // Signifies the cut-over of using type tags instead of `Type`s in the object runtime.
+    #[serde(skip_serializing_if = "is_false")]
+    type_tags_in_object_runtime: bool,
 }
 
 fn is_false(b: &bool) -> bool {
@@ -1958,6 +1962,10 @@ impl ProtocolConfig {
     pub fn resolve_type_input_ids_to_defining_id(&self) -> bool {
         self.feature_flags.resolve_type_input_ids_to_defining_id
     }
+
+    pub fn type_tags_in_object_runtime(&self) -> bool {
+        self.feature_flags.type_tags_in_object_runtime
+    }
 }
 
 #[cfg(not(msim))]
@@ -3495,6 +3503,7 @@ impl ProtocolConfig {
                 }
                 83 => {
                     cfg.feature_flags.resolve_type_input_ids_to_defining_id = true;
+                    cfg.feature_flags.type_tags_in_object_runtime = true;
                 }
                 // Use this template when making changes:
                 //

crates/sui-protocol-config/src/snapshots/sui_protocol_config__test__Mainnet_version_83.snap

@@ -80,6 +80,7 @@ feature_flags:
   enforce_checkpoint_timestamp_monotonicity: true
   max_ptb_value_size_v2: true
   resolve_type_input_ids_to_defining_id: true
+  type_tags_in_object_runtime: true
 max_tx_size_bytes: 131072
 max_input_objects: 2048
 max_size_written_objects: 5000000

crates/sui-protocol-config/src/snapshots/sui_protocol_config__test__Testnet_version_83.snap

@@ -90,6 +90,7 @@ feature_flags:
   enforce_checkpoint_timestamp_monotonicity: true
   max_ptb_value_size_v2: true
   resolve_type_input_ids_to_defining_id: true
+  type_tags_in_object_runtime: true
 max_tx_size_bytes: 131072
 max_input_objects: 2048
 max_size_written_objects: 5000000

crates/sui-protocol-config/src/snapshots/sui_protocol_config__test__version_83.snap

@@ -95,6 +95,7 @@ feature_flags:
   enforce_checkpoint_timestamp_monotonicity: true
   max_ptb_value_size_v2: true
   resolve_type_input_ids_to_defining_id: true
+  type_tags_in_object_runtime: true
 max_tx_size_bytes: 131072
 max_input_objects: 2048
 max_size_written_objects: 5000000

external-crates/move/crates/move-vm-runtime/src/native_functions.rs

@@ -20,7 +20,8 @@ use move_core_types::{
 };
 use move_vm_config::runtime::VMRuntimeLimitsConfig;
 use move_vm_types::{
-    loaded_data::runtime_types::Type, natives::function::NativeResult, values::Value,
+    data_store::DataStore, loaded_data::runtime_types::Type, natives::function::NativeResult,
+    values::Value,
 };
 use std::{
     cell::RefCell,
@@ -158,6 +159,46 @@ impl<'b> NativeContext<'_, 'b> {
         }
     }
 
+    // TODO: This is a bit hacky right now since we need to pass the store, however this is only
+    // used in test scenarios so we have some special knowledge that makes this work. In the new VM
+    // however this is _MUCH_ nicer as we don't need to pass the datastore as the VM's linkage
+    // tables must have the type present.
+    pub fn type_tag_to_fully_annotated_layout(
+        &self,
+        tag: &TypeTag,
+        store: &impl DataStore,
+    ) -> PartialVMResult<Option<A::MoveTypeLayout>> {
+        match self
+            .resolver
+            .loader()
+            .get_fully_annotated_type_layout(tag, store)
+        {
+            Ok(ty_layout) => Ok(Some(ty_layout)),
+            Err(e) if e.major_status().status_type() == StatusType::InvariantViolation => {
+                Err(e.to_partial())
+            }
+            Err(_) => Ok(None),
+        }
+    }
+
+    // TODO: This is a bit hacky right now since we need to pass the store, however this is only
+    // used in test scenarios so we have some special knowledge that makes this work. In the new VM
+    // however this is _MUCH_ nicer as we don't need to pass the datastore as the VM's linkage
+    // tables must have the type present.
+    pub fn type_tag_to_layout(
+        &self,
+        tag: &TypeTag,
+        store: &impl DataStore,
+    ) -> PartialVMResult<Option<R::MoveTypeLayout>> {
+        match self.resolver.loader().get_type_layout(tag, store) {
+            Ok(ty_layout) => Ok(Some(ty_layout)),
+            Err(e) if e.major_status().status_type() == StatusType::InvariantViolation => {
+                Err(e.to_partial())
+            }
+            Err(_) => Ok(None),
+        }
+    }
+
     pub fn type_to_abilities(&self, ty: &Type) -> PartialVMResult<AbilitySet> {
         self.resolver.loader().abilities(ty)
     }